Closed bjorneg closed 3 years ago
Good catch, but the fix is insufficient as the amount is wrong as well (i.e. when equipping tools, the price should have been 300). Looking into this now.
Good catch, but the fix is insufficient as the amount is wrong as well (i.e. when equipping tools, the price should have been 300). Looking into this now.
With fix applied it says "Purchase 100 tools @3 Price 300". Seems OK to me.
Seems OK to me.
You are right. I was even more confused than normal with this area. Consequently I have added a more detailed comment and moved the sign change up to where the MarketWas is created in the hope of not being fooled again. Committed with credit in git.49f90f26 (sf).
There is a mixup of buy/sell when a unit is equiped with tools in Europe.
See attached before screen-shot:![bug_before](https://user-images.githubusercontent.com/32073147/106184639-1d5a8580-61a2-11eb-8c8f-d69f34f3408e.png)
And the after screen-shot:![bug_after](https://user-images.githubusercontent.com/32073147/106184677-29dede00-61a2-11eb-8f81-46f3f4bb38b5.png)
This a purchase of tools. The total amount of gold is decreased correct, However, the purchase is recorded as a sell. (and vice versa for drop tools)
To recreate:
In Europe:
Note: This fix need to be reviewed - it fixes the issue, but is it the right way to fix it? I may be wrong but usually a buy is a negative number, but sometimes not.