WIP: Phpstan 2 - Githubissues

simPod commented 5 years ago

Here is increase to level 2.

[x] Was a bit more tricky thant the previous, had to shuffle class hiearchies a bit.
[x] Found some bugs
[ ] My first time working with PHPSpec but in some cases I think PHPUnit is more suitable. I have added an example of PHPUnit test replacing PHPSpecs it_should_encrypt_data_using_aes128. I have not found a way how to assert the correct values without bending src API. It stopped working as I removed returned Message from encryptData(). Check it out and lemme know WDYT.

simPod commented 5 years ago

@ChadSikorra Hi, will you have a time to look at this? :)

ChadSikorra commented 5 years ago

For sure! Been a hectic week or so with work. Planning on looking at it over the weekend.

ChadSikorra commented 2 years ago

Closing this out as the PhpStan level is now set to max in this library.

FreeDSx / SNMP