search

FreeFalcon / freefalcon-central

A campaign based, multiplayer, open source flight simulator.
http://freefalcon.org/
BSD 2-Clause "Simplified" License
157 stars 99 forks source link

Fix some assertion failure #11

Closed PlutoniumHeart closed 11 years ago

PlutoniumHeart commented 11 years ago

Fix function RemoveInvalidChars(const string &instr)

Signed-off-by: PlutoniumHeart zhitaoli.hust@gmail.com

vinnydiehl commented 11 years ago

If you're doing a small one commit change like this, it's okay to push it directly to develop- if you do a pull request and a topic branch, that's for if you want others to review your code before pulling it in (or if the change that you're making requires several commits, use a branch for that, but don't make a PR and immediately merge it before it can be reviewed).

vinnydiehl commented 11 years ago

Also, don't put your name in front of comments that you make, that feature is built into Git, check it out:

https://github.com/FreeFalcon/freefalcon-central/blame/751e9327e2b3c35a1fb9b1efc443178b5843c9cc/src/graphics/terrain/tdskpost.cpp#L130-131

It remembers who last changed what line and keeps a full history of it. Much nicer than having names and dates slobbered all over the comments like the rest of the code does.