search

FreeFeed / freefeed-server

FreeFeed server
https://freefeed.net
MIT License
41 stars 18 forks source link

trivial risk reduction with docker base image bump up to node:18.16.1-bookworm #633

Closed silpol closed 9 months ago

silpol commented 1 year ago

Snyk scanner for Docker files suggests to bump up version of base image to reduce various risks

image

pull request can be applied to try impact on current codebase

indeyets commented 1 year ago

@silpol this is a major upgrade. NodeJS 18.x is still a supported branch. are you sure those issues are not fixable?

Can you add more details about problems which snyk reports?

indeyets commented 1 year ago

oh, here's the link: https://snyk.io/test/docker/node%3A18.16.1-buster

it looks like the problems are not really node related, but distro related.

can we change distro instead?

indeyets commented 1 year ago

will this work maybe? https://snyk.io/test/docker/node%3A18.16.1-bookworm

silpol commented 1 year ago

@indeyets ok, it makes sense, I have updated pull request