FreeFem / FreeFem-sources

FreeFEM source code
https://freefem.org/
Other
796 stars 193 forks source link

Check .gitignore #2

Closed sgarnotel closed 6 years ago

sgarnotel commented 6 years ago

The automatic conversion from .hgignore to .gitignore failed because of the usage of regex in the .hgignore.

Please, check the .gitignore (branch develop)

fghoussen commented 6 years ago

Would say (not sure !) line 20 of .gitignore (#) should be removed (after stripping comments, lasts !...)

sgarnotel commented 6 years ago

The *# was in the original .hgignore (written in regex) Concerning the comments, are you talking about the GNU header, # headeralh conf default=0 freefem start=2008 upmc written or the comments at the end ?

It would be nice to clean up this file, but we need input from everyone, especially @frederichecht

fghoussen commented 6 years ago

I am in Istanbul since and for a few days with bad/low wifi... So I could only have a quick look ! My opinion is that you should build the .gitignore from scratch and step-by-step (not convert it from hg).

alh104 commented 6 years ago

Hi everyone. I am the one who created this file (alh are my initials). In hg, "(^|/)#" designated emacs temporary files starting with a hash. If you have any other question, please ask.

sgarnotel commented 6 years ago

Thank you for the answer. @fghoussen Re-build the .gitignore from scratch could be dangerous, a lot of files presents on developer's computers could be push in the repository. @alh104 Could you check ,if you can, that the .gitignore is ok? I just translate the .hgignore regex into .gitignore format.

alh104 commented 6 years ago

OK, I'll have a look and get back to you asap.