search

FreeFem / FreeFem-sources

FreeFEM source code
https://freefem.org/
Other
755 stars 188 forks source link

Replaced several occurrences of "Foobar" by "FreeFEM" #222

Closed f-florian closed 2 years ago

f-florian commented 2 years ago

I assume the word "Foobar" is coming from the LGPL license template. It was left untouched at some occurrences in the readme files.

I am aware of the rule "don't push to master" but I believe this is an exception and these changes belong there.

prj- commented 2 years ago

It must be on develop otherwise it will trigger new package builds (.deb, .exe, and such) just for a documentation change. What’s the problem with pushing this on top of develop?

sgarnotel commented 2 years ago

I just change the base branch. Pull request on develop branch is mandatory, for all modifications, for the reasons @prj- explain above, thanks to follow this rule.

f-florian commented 2 years ago

Sorry, I was a bit too quick, I read about the feature specific branches (but this is not strictly a feature), and overlooked develop. Of course it is not a problem pushing there. I now read that the "base branch" was changed, but I am not sure what this means for github, and if I still need to do something. I am happy to close the pull request and reopen it on develop if needed.

prj- commented 2 years ago

It’s not needed to close the PR, GitHub is smart enough to handle this.

sgarnotel commented 2 years ago

All is good for me, I can merge the PR if you are ready

f-florian commented 2 years ago

All is good for me, I can merge the PR if you are ready

If the question was for me, of course you can go ahead.

sgarnotel commented 2 years ago

So, thank you for your contribution