FreeHealth / freehealth

Free and open source Electronic Health Record
https://freehealth.io
Other
44 stars 16 forks source link

Remove base64 encoding of username / login in database #102

Open jeromecc opened 6 years ago

jeromecc commented 6 years ago

base64 encoding of username in the user table does not add any security, but it adds complexity to the code and is annoying when debugging the database Using "crypt" to name a function UserIdentifier::login64crypt() that only encodes a string in base64 is incorrect and misleading. Let's get rid of this and then concentrate on adding complexity where it will be useful: using standard cryptographic password hashing methods.