[WIP] Update cumulative similarities on save

FreeMusicNinja / api.freemusic.ninja

Django-powered API for Free Music Ninja

http://api.freemusic.ninja/

BSD 3-Clause "New" or "Revised" License

4 stars 0 forks source link

[WIP] Update cumulative similarities on save #30

Closed treyhunner closed 9 years ago

treyhunner commented 9 years ago

Should resolve #25

treyhunner commented 9 years ago

While trying to test this I discovered that there appears to be a bug in the artists.tests.test_api.SimilarTest test class because the post_save and pre_save aren't being executed at all.

macro1 commented 9 years ago

@treyhunner, well spotted. I wasn't checking the status code so it wasn't catching the fact that it was trying to post to a non-existing URL. I took the liberty of updating on your branch here.

treyhunner commented 9 years ago

I added a couple tests.

Some missing tests/features:

[x] Add two user similarities for the same artist (currently responds with 500 error)
[ ] Change artist name for user similarity (old UserSimilarity should be removed and Similarity should be updated)

macro1 commented 9 years ago

Your first item might be addressed in DRF 3, we should just wait for the upgrade.

On your second item, I'd rather see PUT removed and the client does a full DELETE and POST. It really isn't the same similarity.