FreeOpcUa / opcua-asyncio

OPC UA library for python >= 3.7
GNU Lesser General Public License v3.0
1.11k stars 358 forks source link

Fix infinite loop causing memory leak in GH-1519 #1531

Closed joshbode closed 9 months ago

joshbode commented 9 months ago

I don't know the codebase/protocol well enough to know whether we can always expect there to be at least one value in the iterator, or whether we need to have a fallback and a check, e.g.

head = next(iter(results), None)
if head is None:
    break
oroulet commented 9 months ago

I reverted change in that other MR: https://github.com/FreeOpcUa/opcua-asyncio/pull/1534. Thank for you help @joshbode !

joshbode commented 9 months ago

Sounds good, @oroulet :)