search

FreeOpcUa / opcua-asyncio

OPC UA library for python >= 3.7
GNU Lesser General Public License v3.0
1.04k stars 346 forks source link

test: Verify loading from shelf files raises an AttributeError #1574

Closed AiyionPrime closed 4 months ago

AiyionPrime commented 4 months ago

This confirms @harriv's finding in #1313.

AiyionPrime commented 4 months ago

@oroulet any objections against merging this test?

oroulet commented 4 months ago

I am not really following here, you want to merge a test that is disabled? What is your goal?

AiyionPrime commented 4 months ago

This tests that storing the shelf indeed fails, as @harriv tested manually. The following PR will resolve the issue.

It's worth noting, that this does not disable the test, but marks it as expected failure. One of the next PRs will then resolve the issue and remove the line of expected failure.

But it's not disabled, it runs and show the problem.

When I started this I expected the problem to be bigger than it effectively was. This PR is ready to merge and I will rebase the others accordingly afterwords.