FreeOps-Tools / LogIQ

LogIQ is an open-source web analysing tool.
https://logiq.netlify.app
MIT License
10 stars 8 forks source link

Updated logo and added multiple requests feature #40

Closed sudhz closed 1 year ago

sudhz commented 1 year ago

Added multiple requests feature

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

image

Note to reviewers

I'm still working on adding timestamp and url in each response.

netlify[bot] commented 1 year ago

Deploy Preview for logiq ready!

Name Link
Latest commit b4656af8a2825af9836c47834546c3c5e6ff0e16
Latest deploy log https://app.netlify.com/sites/logiq/deploys/652ee7deca0aaf0008c05e9a
Deploy Preview https://deploy-preview-40--logiq.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rufilboss commented 1 year ago

How will the user input more than one URL?

sudhz commented 1 year ago
  1. Enter one URL
  2. Click on "Analyze"
  3. The results are shown
  4. Re-enter different URL
  5. Click on "Analyze" again

After this, you'll see both the URL's results

rufilboss commented 1 year ago

image

Ohhh, awesome But can you also work on adding support to indicate the result of each request separately?

rufilboss commented 1 year ago

Addresses #40

sudhz commented 1 year ago

Do you mean to say that I should add the URL and timestamp in each response? Because the response is shown individually for each request.

rufilboss commented 1 year ago

Yeah, you get it

But I was thinking, adding the whole URL won't be that good as it might look nice, what do you think we can do?

sudhz commented 1 year ago

How about setting an ID for each request? Then displaying the ID?

rufilboss commented 1 year ago

Yeah

sudhz commented 1 year ago

Alright, I'll work on it

sudhz commented 1 year ago

Hi, instead of generating a unique ID for each request on the client side, wouldn't it be a better option to do it on the server side and send the response back with the ID? This is the response from the backend URL, which is https://logiqapi.onrender.com/api/analyze: image As you can notice here, there is no ID property. Instead of setting a new unique ID on each request on the client side, wouldn't it be better if we handled it on the server side and sent a response like:

{
   "ID":"ccf7b488-9171-449f-aaca-5e36f94ef455",
   "URL":"https://google.com/",
   "isUp":true,
   "ipAddress":"142.251.33.78",
   "uptime":"99.00",
   "responseTime":"0.16"
}

Now, this would be for a successful response, when the URL is valid.

If the URL is invalid, your backend just sends the following response:

image

Instead of handling the invalid URL requests like this, you can send the response from the backend like:

{
   "ID":"ccf7b488-9171-449f-aaca-5e36f94ef455",
   "URL":"<the invalid url>",
   "isUp":false,
   "ipAddress":null,
   "uptime":null,
   "responseTime":null
}

What are your thoughts on this?

rufilboss commented 1 year ago

Yeah yeah, I want to said it ealier

rufilboss commented 1 year ago

Do you have time to work on it on the backend side?

sudhz commented 1 year ago

Yeah, sure, let me know the details