[bug]: Issues with the Calendar Module and iCal links to google calendar.

digiaust commented 2 months ago

FreePBX Version

FreePBX 15

Issue Description

Hi there, thank you for all your work on this project.

Found a few issues with Calendaring when linking to a Google calendar and creating repeating events.

Events that repeat by more than every 2 weeks just repeat weekly no matter the range. (Tested every 2 weeks to every 8 weeks)
Week-long events that have time set at the same start and end time (but different days) will not show times and will occur at midnight (and not display times) instead of set times.
Events that are set to reoccur more than every 30 days (daily) (as a workaround to the reoccur weekly issue) will not reset BLF status until feature code is toggled. (Calendar and call flow operate properly but BLF keys are stuck and do not switch to unmatched despite calendar reflecting event has ended)

All issues occur when creating calendar events in a Google Calendar that has been linked to FPBX via Remote iCal
All issues affect FPBX version 15.0.37.4 (Asterisk Version: 16.30.0) and 16.0.40.7 (Asterisk Version:16.30.0) (Tested on 4 different servers, each 15 or 16)
All tested servers with issues are hosted on: Operating System: Sangoma Linux 7 (Core) CPE OS Name: cpe:/o:sangoma:sng:7::server:utf8 Kernel: Linux 3.10.0-1127.19.1.el7.x86_64
Browsers used and tested in: Chrome Version 123.0.6312.106 (Official Build) (64-bit) Firefox Version 124.0.2 (64-bit)

Issue 1: Events that repeat weekly, more than every 2 weeks, just repeat weekly.

Issue: When creating an event that needs to repeat every 2+ weeks in Google Calendar, events will just be repeated weekly.

Reproducibility: 98%.

Expected: Events should repeat at the specified intervals, such as every 3 weeks, without reverting to weekly repetition.

Actual: Events set to repeat every 2+ weeks revert to repeating weekly.

Steps to Reproduce:

Link a Google Calendar to FPBX via Remote iCal.
Create an event and set it to repeat every 3 weeks.
Observe that the event repeats weekly instead of every 3 weeks.

Issue 2: Multi-day events that start and end at the same time do not show the time in Calendar/Event View and occur at Midnight instead of set time.

Issue: Week-long events with the same start and end time across multiple days fail to display times and default to occurring at midnight.

Reproducibility: 90%.

Expected: Multi-day events should display and occur at the set times, regardless of the event duration.

Actual: Events are scheduled at midnight and do not display set times in the calendar.

Steps to Reproduce:

Link a Google Calendar to FPBX via Remote iCal.
Create a multi-day event, setting the start and end times to be the same.
Observe that the event time is not displayed and defaults to midnight.

Issue 3: Events that are set to reoccur more than every 30 days properly reoccur in the calendar and in regards to the call flow but BLF hints remain stuck.

Issue: Events set to recur every 30+ days display correctly in the calendar and affect call flow as expected, but BLF hints do not reset post-event without toggling the feature code.

Reproducibility: 95%.

Expected: BLF status should automatically update to reflect the end of an event.

Actual: BLF keys remain stuck and do not switch to "unmatched" status despite the calendar reflecting that the event has ended.

Steps to Reproduce:

Link a Google Calendar to FPBX via Remote iCal.
Set an event to reoccur every 31 days.
After the event, observe that the BLF status does not reset unless the feature code is toggled manually.

Operating Environment

All issues affect FPBX version 15.0.37.4 (Asterisk Version: 16.30.0) and 16.0.40.7 (Asterisk Version:16.30.0)

Calendar 15.0.10 Stable

Relevant log output

No response

digiaust commented 2 months ago

Regarding issue 3: Events set to repeat every more than 30 days BLF hints remain stuck and do not update:

It might have something to do with FPBX inability to repeat an event more than every 30 days in the calendar module:

Google Calendar with event set to repeat daily, but more than every 30 days:

Same Calendar reflected in FPBX shared via iCal link. (Notice repeating days are not shown): (The calendar events are still accurately reflected in the calendar. The time condition still works to route call flows properly, but the BLF hints do not update.

Notice however, a repeat every X days event under 30 days reflects accurately and BLF hints function normally.

digiaust commented 2 months ago

Regarding Issue 2: Multi-day Events that have the same start and end times do not reflect the set time and revert to midnight (00:00):

Google Calendar with multi-day event that starts at 7:00am and ends at 7:00am two days later:

Same Calendar reflected in FPBX: (Notice only the dates are set, no time)

This time condition will toggle at midnight instead of the set time in the calendar.

Notice that when changing the time 1 minute apart, FPBX then recognizes the set times.

Google Calendar event starting at 7am Monday and ending 7:01am Wednesday

Notice now in FPBX Cal the time is reflected:

Changing the time back to 7a-7a reverts it to the bug where the time reverts to midnight

digiaust commented 2 months ago

Regarding Issue 1: Events repeated more than every 1 week are just repeated weekly

I think resolving this issue will resolve Issue 3 as the correct way to repeat an event more than X+ days is to do it weekly. Currently however when trying to repeat an event more than 1 week, (eg every 3 weeks) the event will just duplicate weekly.

See original event in Google Calendar: This event is set to repeat every 2 weeks (every other week)

See event in FPBX repeating every week:

This despite the UI showing it is a bi weekly event.

The time condition and BLF will be activated every week as displayed on the calendar despite being an every other week event.

This remains true no matter how many weeks between the event should repeat.

Every 4 weeks:

Every 4 weeks on calendar in FPBX:

Every 4 weeks in event in FPBX:

It however doesn't seem to affect monthly or yearly events:

May:

June:

July:

FreePBX / issue-tracker