#4 Improve reliability and test under Ubuntu 22.04.4 LTS

[tdltdl]

Improved the script by

• adding error handling (trap and set -e)
• made idempotent (example do not add the same lines to config files multiple time, do not attempt to create the user and group multiple time)
• Update all repositories before th first run to ensure we have consistent packages and version
• made log file unique (so we keep an history of the executions)
• Improved speed by installing many packages in one go instead of one at a time
• Ensured that signing keys are correctly added (using the new gpg signatures instead of the deprecated add-key)
• Ensure only installed architecture is referenced (not arm64 when the system is an amd64 and vice-versa)
• Use the fully qualified host name to setup postfix
• Remove bc as it is only used to compute processing time (up to the hundreds of seconds, while it takes minutes to run (the hundreds of seconds are irrelevant)
• added fwconsole ma install sangomaconnect as without it, the installlocal was failing

[kguptasangoma]

Hi @tdltdl Excellent PR. Thanks a lot for your time to improve the script.

I just have concern in pkg_install api as we like to terminate the installation if any of the dependent package failed to install so for now i have merged your PR and reverted pkg_install function so we can test it locally asap.

[tdltdl]

just have concern in pkg_install api as we like to terminate the installation if any of the dependent package failed to install so for now i have merged your PR and reverted pkg_install function so we can test it locally asap.

As indicated when using apt install, if any dependency fails to install the exit code will be non-zero and this will be catched by the set -e at the beginning of the bash script. So this is not an issue. You can try is by adding a non-existing package tot he list of packages and see that the script stops. You can test is with this script (run as root):

#!/bin/bash
set -e
echo "I should be the last line you see."
apt install XxxxXxxx
echo "you should not see me."

Of course with this PR merged, you'll also have the last command, return code and so on generate but this is because of the trap error