FreePBX / superfecta

Provides simultaneous use of, and complete control over multiple caller id data sources.
http://www.freepbx.org
GNU General Public License v2.0
58 stars 93 forks source link

Austria herold wrong url #131

Closed easyhugo closed 11 years ago

easyhugo commented 11 years ago

hi

the url in the austria search are wrong the right url where http://www.herold.at/telefonbuch/telefon_ but these are the only that i can do for the rest i need a developer

lgaetz commented 11 years ago

@easyhugo thanks for the bug report. I have made some changes that seem to work for me, but this module needs more testing.

If you are using Superfecta 2.2.6.1 then you can get the update automatically by clicking "Check for Data Source File updates online". If you are using an older version of Superfecta you will have to manually update.

easyhugo commented 11 years ago

hi guys

the update did it thanks for your work

charles-darwin commented 10 years ago

Hi, I just installed the newest stable freePBX distro with Superfecta module 2.11.12. Cannot find the Herold Austria lookup source in the list provided by Superfecta. Is it gone? Do I have to manually install it? Thanks

charles-darwin commented 10 years ago

Just realized that in the old version 2.2, there still is a Herold Austria file and an open79XX file (both are very useful). Any reasons why it is not supported anymore? The old files are php, the new ones "modules". Is there a way to use the old ones in Superfecta 2.11? Thanks

lgaetz commented 10 years ago

@charles-darwin: The module for Herold Austria won't be officially migrated until we get confirmation that Superfecta usage complies with the Terms of Service. We need a native speaker to review the terms and post here with a link to the page, a summary of the relevant parts so we know that automated lookups are permitted. Is this something you can do for us?

The Open79xx module was just never migrated from the old 2.2.x platform. You are the first person to ask for it back. I will make a point to write a new version for 2.11.x, but it will be up to you to test. I will post progress on this in ticket #42

charles-darwin commented 10 years ago

On my old freePBX (asterisk 1.8) system, the lookup in open79xx worked by using the FreePBX standard module - CID lookup source and mysql:

CID Lookup source

Sourcetyp: mysql

Host: localhost Database: open79xx Query: SELECT display_name FROM contacts WHERE cell_phone LIKE '%[NUMBER]%' OR home_phone LIKE '%[NUMBER]%' OR office_phone LIKE '%[NUMBER]%' OR other_phone LIKE '%[NUMBER]%' Username: root Password: xxxx

Don't know, if this works in sqlite too...

I will check the terms of service, but as far as I remember Herold does not like it. There is another Austrian service though, which might permit automated lookups. I will post it here.

I am happy to test your work ;-)

lgaetz commented 10 years ago

Until we get a dedicated module for open79xx working, you can use the generic database module on 2.11 called SFDatabase and this query:

SELECT `display_name` FROM `contacts` WHERE `cell_phone` REGEXP :theregex OR `home_phone` REGEXP :theregex OR `office_phone` REGEXP :theregex OR `other_phone` REGEXP :theregex LIMIT 1
charles-darwin commented 10 years ago

Thanks, Igaetz

Herold Austria - terms of service http://www.herold.at/fileadmin/herold/docs/agb/AGB__HEROLD_Portale_V03_20032013.pdf I only found one important sentence: "Unzulässige Tätigkeiten: Handlungen, die das einwandfreie Funktionieren des Dienstes unmöglich macht oder den Dienst stört oder überbelastet sowie jede Form und jeder Versuch einer Denial-of-Service Attacke;" It says that they don't allow any actions, which disturb the proper function of the service...and they don't like denial-of-service-attacks...(Surprise ;)

EDIT: There is another important sentence "Folgende Tätigkeiten des Nutzers sind untersagt: • Zugriff auf Inhalte und Verwendung der Online-Services zum Zwecke der Sammlung von Daten und Inhalten;" It says that they don't allow access to their service for data collection purposes. I don't think automatic lookup is data collection...

A major German telephone company (www.auerswald.de) provides a Herold (Yellow and White pages) Lookup in their VOIP/ISDN software, so it shouldn't be a problem. I can send you a screenshot of the Auerswald webinterface...

lgaetz commented 10 years ago

@charles-darwin can you email me instructions on how to do a reverse number lookup using Herold? Include a link to the page where you put the number and a working number. I don't speak German, and google translate is not helping.

*edit My email address is the same login name at gmail.

charles-darwin commented 10 years ago

@lgaetz I sent you an email containing the link to the English version of Herold Austria http://www.herold.at/en/telefonbuch/ I didn't know that it exists ;-) Unfortunately, my skills are rather limited...and I cannot provide any instructions regarding the reverse lookup using Herold. Auerswald ist still using its 2012 template for the reverse lookup at Herold, so maybe the old version of the Superfecta Herold file still works?

lgaetz commented 10 years ago

@charles-darwin A version of herold.at is available for testing: https://raw.githubusercontent.com/POSSA/Caller-ID-Superfecta/develop/sources/source-Herold_Austria.module

I was able to get residential lookups working, but not business. If you can get the site to reliably return business names from business numbers, email me with the relevant link and a small list of working numbers.

charles-darwin commented 10 years ago

@lgaetz Thank you very, very much!!! You are a genius! Works like a charm... Open79xx works too ;-)

Herold_Austria Superfecta at work: herold_austria

Thanks CD

charles-darwin commented 10 years ago

Regarding the Herold Yellow Pages, I can only provide you a link, which gives you the field descriptions in English. http://www.herold.at/en/

Here again another version of the white pages: http://www.herold.at/en/telefonbuch/

Numbers for testing: Austrian chancellery 0800222666 (Herold White Pages) American embassy in Austria 01313390 (Herold Yellow Pages) British American Tobacco 0120512260 (Herold Yellow Pages) American International School in Vienna 01401320 (Herold Yellow Pages) American International School in Salzburg 0662824617 (Herold Yellow Pages) 01 and 0662 are area codes of Vienna and Salzburg. Most area codes in Austria have 5 digits, though. 0800 is the code of a free toll number

charles-darwin commented 10 years ago

I found the Herold Business URL (Yellow Pages)! Took me hours ;-) Herold Yellow Pages somehow blocks any URL requests...HOWEVER ... there is a combined search for mobile devices (Herold White & Yellow Pages). This URL works http://www.herold.mobi/suche/was_telefon_/

Numbers for testing...see above...

Here's an example for Yellow: http://www.herold.mobi/suche/was_01313390/

...and here for White: http://www.herold.mobi/suche/was_0800222666/

Here`s the page with limited english support ;-) http://www.herold.mobi/suche/was_01313390/?lang=en