tm1000 commented 13 years ago

Lets start some discussion on what we do next. Do we release 2.2.5? do we wait? What do you guys think

lgaetz commented 13 years ago

I vote that we test for a week or two in the wild (hopefully a some other testers will come out of the woodwork) and then release it.

tm1000 commented 13 years ago

Rossiv wants to test 3.x maybe I can get him to test 2.2.5

I need to test the source update/add methods. So I suggest you delete some sources and see if you can add them through the gui.

ukstevef commented 13 years ago

Is there any chance of a beta cycle with some friendly testers before we announce GA ?

Looks like the new source I added numberGuru has changed their website - can we disable this from the 2.2.5 release until I track down why they are throwing 404 errors on pages that used to work.

tm1000 commented 13 years ago

disable...hm....not really. The only way to disable in 2.2.5 is remove the module from bin

Which brings up an interesting point about 3.x :-)

ukstevef commented 13 years ago

OK tactically nuke it for now - it was never in the wild anyway.

I noticed v3 and the lack of bin :-/

lgaetz commented 13 years ago

I sent a note to rossiv already re: testing of 2.2.5 I already deleted some sources and successfully readded with no issues. I also noted the issue with NumberGuru, but made no effort to track it down. I assumed that I got banned.

I have another source ready to go for canada but I am too dumb to figure out how to get it to github. It is on colsolgrp, don't be confused the the name similarity, it is a different souce. can be dloaded from here: http://projects.colsolgrp.net/projects/superfecta/repository/raw/branches/v2.2.4.x/bin/source-Canada411.php

ukstevef commented 13 years ago

Take a look at SmartGit I am using this and it is very capable.

tm1000 commented 13 years ago

Yes smartgit is pretty outstanding. I used it in the beginning. Now I just use CLI. But SmartGIT does everything you need.

Just make sure you work on the branches only. We should only merge into master with our current release

lgaetz commented 13 years ago

Okay, commit changes to branches only, no problem. Where does the live update pull files from, the master branch or some other location?

ukstevef commented 13 years ago

In the GUI you select which branch you are working on, and all changes are reflected in that branch.

On 1 August 2011 20:26, lgaetz < reply@reply.github.com>wrote:

Okay, commit changes to branches only, no problem. Where does the live update pull files from, the master branch or some other location?

Reply to this email directly or view it on GitHub:

https://github.com/tm1000/Caller-ID-Superfecta/issues/17#issuecomment-1703204

lgaetz commented 13 years ago

I did it. Smartgit is the link I was missing. Now my only tears are tears of joy.

tm1000 commented 13 years ago

Live update pulls from the master branch. Unless it's the 3.x branch which only pulls from the 3.x branch

Sent from my iPhone

On Aug 1, 2011, at 12:26 PM, lgaetz reply@reply.github.com wrote:

Okay, commit changes to branches only, no problem. Where does the live update pull files from, the master branch or some other location?

Reply to this email directly or view it on GitHub: https://github.com/tm1000/Caller-ID-Superfecta/issues/17#issuecomment-1703204

tm1000 commented 13 years ago

Actually I was just thinking. I think I'm going to change live update to pull from the 2.2.5 branch because when we switch to 3.x if it's tracking master it will ruin the 2.2.5 versions. Best to have them all track on their respective branches

Sent from my iPhone

On Aug 1, 2011, at 12:43 PM, lgaetz reply@reply.github.com wrote:

I did it. Smartgit is the link I was missing. Now my only tears are tears of joy.

Reply to this email directly or view it on GitHub: https://github.com/tm1000/Caller-ID-Superfecta/issues/17#issuecomment-1703344

ukstevef commented 13 years ago

NumberGuru requires cookies to be set before searching.

The following fixes it for me

// www.numberguru.com needs a cookie
$temp_cookie_file = tempnam("/tmp", "CURLCOOKIE");
// Get the cookie set
$value = $this->get_url_contents("http://www.numberguru.com",false,"http://www.numberguru.com",$temp_cookie_file);
// Perform lookup using cookie
$url = "http://www.numberguru.com/s/{$thenumber}";
$value = $this->get_url_contents($url,false,"http://www.numberguru.com",$temp_cookie_file);
// Delete the temporary cookie
@unlink($temp_cookie_file);```

tm1000 commented 13 years ago

You'll want to set the tmp directory to the local module folder because you need to set it to a place where you can be sure you'll always have access.

tm1000 commented 13 years ago

I hope this will help future developers and maybe you two also

https://github.com/tm1000/Caller-ID-Superfecta/wiki/Working-with-GIT

tm1000 commented 13 years ago

Ok we are doing this now (just cleaning up tickets)

tm1000 commented 13 years ago

Ok. Should we go with a wider release? How many people have a copy now?

lgaetz commented 13 years ago

I am running on 2 machines since 2.2.5 was released, I have another machine that got it installed a few days ago. MT has been using for about a week, and I can only assume that he would speak up if he had issues. I sent rossiv a note a week ago with no word back.

tm1000 commented 13 years ago

ok. It's up to you. We can release 2.2.5.1 once I see if #30 is really an issue or not

lgaetz commented 13 years ago

30 is a feature request for something that never existed. Given that 2.2.x series is coming to a close, unless it is easy to implement I vote this be worked on in 3.x and forward.

tm1000 commented 13 years ago

I just had to removed a tag in the XML. It's about the easiest thing in the whole coding world, reference a6597c4 for more info

lgaetz commented 13 years ago

I have upgraded 3 low traffic purple installs to 2.2.5.1 and will monitor, tho I am pretty confident that I have caught all the bugs I am going to. With the approval of the devs here, I suggest we start a new PIAF thread; I propose the following wording as a starting point:

Subject: CID Superfecta 2.2.5 BETA 1 available for download and testing

Caller ID Superfecta 2.2.5 BETA 1 is available for immediate download and testing. This is a maintenance release of the 2.2.x branch and incorporates the following bugs/fixes/features/lookups:

Revised to work unmodified with FreePBX version 2.9
Overhauled the live update mechanism
Includes several new and revised lookup sources that were previously only available via manual download and install
Fixed bug that would not permit rules to strip a leading zero
Minor edits and tweaks too numerous to identify individually.

As clearly stated above, this is a BETA release of the software; it has been tested, but not widely so. We do not recommend this update be applied to critical systems, nor is there any reason to upgrade if your current installation of Superfecta is working fine.

All users of FreePBX 2.9 and the Google Voice Module should be aware that the first attempt at patching the GV module for 2.9 compatibility will break every version of CID Superfecta and possibly other modules as well. If you are running FreePBX 2.9 you need to check into this thread link to 2.9 gotchas and stay on top of issues as they arise there.

If you have read the above and you want to upgrade/install CID Superfecta 2.2.5 BETA 1, you can find installation instructions here link to github wiki Installing-Caller-ID-Superfecta-v2.2.5-Module-for-FreePBX Since this is a beta release, please report your experiences here (even successes) so that we can gauge the module's suitability for general release.

In case you missed it in the text above, CID Superfecta 2.2.5 BETA 1 is a BETA release.

lgaetz commented 13 years ago

Ok I have finished my thoughts above, chime in with anything I missed. Let me know if you want me to post it, whoever wants to can just grab the text and do it.

tm1000 commented 13 years ago

Should I put the beta tag on the end of the version number?

Eg: 2.2.5.1beta1

lgaetz commented 13 years ago

Dunno. If you do use beta1, perhaps it should be renumbered to 2.2.5beta1 with the final release numbered as 2.2.5?

tm1000 commented 13 years ago

ok. Will do that instead then.

tm1000 commented 13 years ago

http://www.the159.com/superfecta/superfecta-2.2.5beta1.tgz

ukstevef commented 13 years ago

2.2.5beta1 is the way to go. Let the feedback roll ....

lgaetz commented 13 years ago

"let the feedback roll ..."

As long as feedback is not another word for *hitstorm. The wording above has been amended to the new version number.

MichiganTelephone commented 13 years ago

Seems to be working fine. I vote for release.

lgaetz commented 13 years ago

Andy? Was your latest upload to the159.com your signal to post to the PIAF forum?

tm1000 commented 13 years ago

Yes

Sent from my iPhone

On Aug 8, 2011, at 6:08 PM, lgaetz reply@reply.github.com wrote:

Andy? Was your latest upload to the159.com your signal to post to the PIAF forum?

Reply to this email directly or view it on GitHub: https://github.com/tm1000/Caller-ID-Superfecta/issues/17#issuecomment-1759857

lgaetz commented 13 years ago

Done. http://pbxinaflash.com/forum/showthread.php?p=69373#post69373

FreePBX / superfecta

What's Next? Release 2.2.5? Wait? #17

30 is a feature request for something that never existed. Given that 2.2.x series is coming to a close, unless it is easy to implement I vote this be worked on in 3.x and forward.