search

FreePBX / superfecta

Provides simultaneous use of, and complete control over multiple caller id data sources.
http://www.freepbx.org
GNU General Public License v2.0
56 stars 92 forks source link

Ensure latest version of GoogleContacts is in 13 #261

Closed ntadmin closed 8 years ago

ntadmin commented 9 years ago

From my note on pull request #256, the bug removed in that merge doesn't seem to made it to 13. Even more oddly, none of the code seems to be there, hence this pull request.

Just to be clear: this only contains, to the best of my knowledge, the working version of GoogleContacts. There is no work on speed ups, AGI or anything like that. The only changes are those noted in pull requests #245, #248 and #256.

245 and #248 (but not #256) appear in the most recent release (superfecta 13.0.3.2) but none in branch release/13.0 on github.

All three are in release/2.11 on github. I would suggest that either all three should be in release/13.0, or none! The current scenario provides a broken on first use version of Google Contacts.

ntadmin commented 8 years ago

Closed because various forks and branches are out of sync at my end, so I am resyncing and will then create a better pull request to ensure working code in release/13.0