search

FreePBX / superfecta

Provides simultaneous use of, and complete control over multiple caller id data sources.
http://www.freepbx.org
GNU General Public License v2.0
58 stars 93 forks source link

Trunk Module should ignore Route Prefix #268

Open daocow opened 8 years ago

daocow commented 8 years ago

We use CID Name Prefix on inbound routes to show the DID the call came in on.

The problem is that when the CID Name has the route prefix added, it no longer matches either the Keywords or the Discard Numeric in the Trunk module config so the Trunk CID is always selected instead of failing through to other modules.

This is somewhat related to issue #180 and could probably be treated generically by removing the prefix at the beginning of any processing and then adding it on afterwords but should be done at least for the Trunk module where the existing value is tested and used.

daocow commented 8 years ago

So here is a patch for the trunk module against the most recent code in FreePBX.

patch1.txt

lgaetz commented 8 years ago

Thanks for the contribution. All code submissions must have a corresponding licensing agreement on file. If you have not already done so, can you please follow the instructions on this page: http://wiki.freepbx.org/display/FOP/Code+License+Agreement

daocow commented 8 years ago

I have signed the license agreement already under the freepbx username dosborn

lgaetz commented 8 years ago

Understood, as soon as @tm1000 confirms, I will investigate your patch.

Thanks for the contribution!