search

FreePBX / superfecta

Provides simultaneous use of, and complete control over multiple caller id data sources.
http://www.freepbx.org
GNU General Public License v2.0
56 stars 92 forks source link

Update source-Can411.module #321

Closed adamvallee closed 5 years ago

adamvallee commented 5 years ago

I have updated the URL and REGEX for Can411.

Currently, the module is pulling the name and address and all kinds of garbage out of the <a href... /a> attribute.

lgaetz commented 5 years ago

Thanks @adamvallee! I use this source as well and have noticed the same thing, just never got around to fixing.

@tm1000 tested and works as expected, I recommend it be merged.

jfinstrom commented 5 years ago

All code submissions require a CLA: http://wiki.freepbx.org/display/FOP/Code+License+Agreement

adamvallee commented 5 years ago

Thats fine, someone working for the company can "submit it" it is a broken source in a module that they provide in software that they are making money off of, they can figure it out. Im not filling out any forms or signing anything. They know it doesn't work... They need to fix it...

On Mon., Jul. 1, 2019, 3:52 p.m. James Finstrom, notifications@github.com wrote:

All code submissions require a CLA: http://wiki.freepbx.org/display/FOP/Code+License+Agreement

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FreePBX/superfecta/pull/321?email_source=notifications&email_token=AGM4XGOV7NBW3Y5UNZBSV33P5JOBFA5CNFSM4G23PC4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7FLKA#issuecomment-507401640, or mute the thread https://github.com/notifications/unsubscribe-auth/AGM4XGOBBDH4FCMQXAFAYT3P5JOBFANCNFSM4G23PC4A .

jfinstrom commented 5 years ago

This is a Open Source GPL module it is not sold. No money is made off these modules and the sources are generally community maintained. If a source is broken and nobody wants to fix it the source may get removed.