search

FreePBX / superfecta

Provides simultaneous use of, and complete control over multiple caller id data sources.
http://www.freepbx.org
GNU General Public License v2.0
58 stars 93 forks source link

v2.2.5 sources left to migrate to v3.x #42

Closed ukstevef closed 9 years ago

ukstevef commented 13 years ago

The following need to be converted.

lgaetz commented 13 years ago

I could probably venture into helping on ver. 3.x but I don't have v. 3 installed anywhere at the moment. I now have a low call volume (PIAF purple) server set up at home which I can use for this purpose, is it possible to get a somewhat stable version of the module built to replace the Aug 1 issue, say 3.0.2alpha? With a bit of effort, I should be able to migrate lookup sources to free up dev's for real coding.

No hurry on this, it will be a while before I am in a php frame of mind.

ukstevef commented 13 years ago

The source for v3.x is in my opinion much easier to work with as we now have abstracted a great deal of the repeated code into superfecta_base functions.

I would look at a few sources to see how they have been converted e.g. Google_Maps_UK and then look at the called functions in the base class.

I would be interested to see how much easier you find this new approach.

tm1000 commented 13 years ago

Yes. Let me fix what I broke in terms of the GUI that Steve has been dealing with very patiently.

ukstevef commented 12 years ago

Added Dominican Republic to list #56

ukstevef commented 12 years ago

6b3e92505d0c6ec89e89fb74643a1589e7caa154 migrates PaginasAmarillas_DO to v3.x

ukstevef commented 12 years ago

Added source-Abandon_lookup to list of things to move over to v3.x

lgaetz commented 12 years ago

I don't see the "superfecta cache" on this list, did it get moved to the core code or is that an oversight?

edit Found the code, never mind.

ukstevef commented 12 years ago

source-Superfecta_Cache.module was already converted - so was not in the list :-)

lgaetz commented 12 years ago

source-FreeCNAM has been officially deprecated, it should be removed from ver. 3.0. Lookups still work, so it can remain in the master branch for the time being until OpenCNAM gets pushed.

lgaetz commented 12 years ago

All Canada only sources have been updated/migrated as of Jun 19, 2012

lgaetz commented 11 years ago

Summary of TOS as of May 16, 2013 for Australian sources:

http://personlookup.com.au/

I have searched throughout this site for anything that might limit usage and there is absolutely nothing. At the bottom of each page, there is the single word "disclaimer" that links to nothing. IMO, from what is stated on the site, this source can be migrated without issues.

http://www.reverseaustralia.com/

This site's Acceptable Use Policy is not too complicated and most of it does not apply to Superfecta operation except perhaps this part:

Avoiding System Restrictions. Using manual or electronic means to avoid any use
limitations placed on the Services such as timing out [is prohibited].

I don't think this clause applies to Superfecta and IMO this source can be migrated.

https://reversephones.com.au

This site has already been migrated. The Legal is very simple and only restricts the user from downloading a "significant portion" of the database. IMO, normal Superfecta usage is in compliance and can be migrated.

http://www.superpages.com.au/

TOS are here Very simple page with almost no content. This line

No part of the web site may be reproduced, republished, copied, transmitted or distributed
in any form by any means.

would seem to indicate that nobody can use the site in any way for any reason. Since they obviously permit normal web access to the site, I think it is reasonable to assume that they don't prohibit normal Superfecta usage. IMO this source would be safe to migrate.

http://truelocal.com.au/

Buried in the exhaustive Terms and Conditions is this line

[Users will not] send automated queries of any kind to the Site or the directory
without ALS’s express written permission.

I think this pretty clearly prohibits Superfecta from using this site.

http://www.yellowpages.com.au/

Terms and Conditions are here which contain these lines:

b. Users must not, whether through the use of additional software or by any other means, data
    mine or conduct automated searches on this site or the data contained in it.

c. However, users may download individual listings for their own private use in the course
    of the normal use of this site for directory assistance purposes.

Clause b. seems to disallow superfecta usage, but clause c. can easily be interpreted to permit it, if you consider Superfecta to be 'normal use' which they don't define. IMO this source can be migrated.

lgaetz commented 11 years ago

Summary of TOS for Canadian sites as of May 16, 2013:

Canada411.ca

TOS redirect to ypg.com and Superfecta appears to be prohibited by this line:

7. Web Scraping/Harvesting. The framing, scraping, data-mining, extraction or collection of the Content of the Sites in any form and by any means whatsoever is strictly prohibited.

Canpages.ca

TOS redirect to ypg.com with same terms as for canada411.ca, prohibited

Can White Pages at whitepages.ca

TOS are found at whitepagesinc.com which includes:

You will not use any type of automated means to utilize the Offerings or Materials;

IMO Superfecta usage is not permitted.

411.ca

There is a lot of text to the TOS split 50-50 between user TOS and advertiser TOS. I don't see anything in the user section with regard to definitions to normal usage or restrictions on how a user might access data. IMO this site can be migrated to Superfecta. The code is already done in the 3.x branch: /modules/source-Can411.module

lgaetz commented 11 years ago

I see telco data has been removed from the last release of 2.11.x. There is nearly no legalese on that site, and the FAQ doesn't define what acceptable use it, it just specifically states that spiders are not permitted. IMO superfecta is acceptable use.

So there is no doubt, I can contact that site admin and ask for a ruling, unless that has been done already.

lgaetz commented 11 years ago

Send_to_email migrated today, outstanding Send_to modules are Send_to_SMS and Send_to_Soundbridge

tm1000 commented 11 years ago

<3 @lgaetz still going strong where all others have dropped off.

tm1000 commented 11 years ago

We can put telco data back. The data just isnt that great.

lgaetz commented 11 years ago

Agree with your assessment of telco data, but I still use it a lot because cell phones make up an ever increasing number of our inbound calls with no trunk provided CNAM and no sources for cell CNAM, geographical location is the best we can do.

As far as "still going strong", holy cow we could use some coders here. If you or I get abducted by aliens POSSA will die.

adamgoldberg commented 11 years ago

I'm game. Someone give me an assignment....

Adam adam@agp-llc.commailto:adam@agp-llc.com

On Aug 14, 2013, at 7:05 AM, "Lorne Gaetz" notifications@github.com<mailto:notifications@github.com> wrote:

Agree with your assessment of telco data, but I still use it a lot because cell phones make up an ever increasingly number of our inbound calls with no trunk provided CNAM and no sources for cell CNAM, geographical location is the best we can do.

As far as "still going strong", holy cow we could use some coders here. If you or I get abducted by aliens POSSA will die.

— Reply to this email directly or view it on GitHubhttps://github.com/POSSA/Caller-ID-Superfecta/issues/42#issuecomment-22633735.

lgaetz commented 11 years ago

@adamgoldberg Post one of this thread should have a complete list of all 2.11 Superfecta sources. Any that are struck through have been migrated from 2.2 already or have been determined not to be in compliance with the sites TOS and will therefore not be migrated. Any information in post 1 you see that is out of date let us know and I will update it.

Don't assume that post 1 is 100% accurate. Before doing any work check the 2.11 branch /sources folder for a module in case it has been done already. Don't assume that the TOS has been investigated if it is not noted in this thread. We are only migrating sources that are in compliance.

Commit changes to the 2.11 branch, or since you don't have a history of commits you may find it easier just to email your work to me and I will upload for you. My email address is my github handle at gmail.com. Any questions, post here or email.

Not sure where your interests lie, you may want to contribute to any of the other POSSA projects. Most have one or more issues outstanding or some unfinished feature; check the issue tracker.

lgaetz commented 11 years ago

I have added Can411 (searches 411.ca) and telco_data back to the 2.11 branch. IMO, Superfecta is acceptable usage of 411.ca per the site's TOS (see post above).

tm1000 commented 11 years ago

Fine by me. Thanks

lgaetz commented 10 years ago

Previous commit migrates Reverse Australia by user request. Currently there is no number validation.

lgaetz commented 10 years ago

The 2.2.x version of Who_Called lookup source was substantially updated after migration to 2.11 and the updates were never made to the 2.11 version.

Reported here: http://pbxinaflash.com/community/index.php?threads/caller-id-superfecta-whocalled-us-spam-return-0.13787/

tm1000 commented 10 years ago

Spam was removed from the 2.11 version because it's tainted from bad coding. Mainly if you enable spam I can't call any of my clients because of how tshift coded the module at some point in the past, (basically every call in was reported back to whocalled.us, and since I was developing version 3 I am all over whocalled.us)

lgaetz commented 10 years ago

Thanks for the reminder, I had totally forgotten the history from ticket #26. I just scanned the API notes here: http://whocalled.us/about and I am pretty sure we can query both the name and the spam score without reporting anything. When formatting the URL, acceptable values for ?action= are report, comment, getscore and getwho. If we stay away from report and comment, I don't think any data is sent to whocalled, we will just use getscore and getwho.

I will do a bit of testing to verify.

lgaetz commented 10 years ago

The send to xbmc module in the 2.2 branch has substantially more functionality than the 2.11 branch, improvements were made by @soif that were never migrated to 2.11.

lgaetz commented 10 years ago

Initial migration for Open79xx ready for testing available from here: https://raw.githubusercontent.com/POSSA/Caller-ID-Superfecta/develop/sources/source-Open79XX.module

att: @charles-darwin

charles-darwin commented 10 years ago

Wonderful! Thanks!!!! .-)

open79xx works!

Debug is on and set at level 3 The Original Number: 06802150803 The Scheme: Default Scheme Type: SINGLEFECTA SPAM Destination: is CLI: false Debugging Enabled, will not stop after first result. Scheme Variables:

Array ( [order] => 1 [Curl_Timeout] => 1.5 [SPAM_Text] => SPAM [sources] => Open79XX,SFDatabase [spam_interceptor] => N [spam_destination] => [Prefix_URL] => [processor] => superfecta_single.php [multifecta_timeout] => 3 [SPAM_Text_Substitute] => N [DID] => [CID_rules] => [SPAM_threshold] => 3 )

Trunk Variables:

Array ( [channel] => NA [language] => NA [type] => NA [uniqueid] => 320654849 [callerid] => 06802150803 [calleridname] => unknown [did] => [context] => from-superfecta )

Connecting to Open79xx database.... Connected to Open79XX database! Searching Open79XX Database... Found.. 'Darwin, Charles' result took 0.0024 seconds.

Connecting to database.... Connected! Searching Database... Found.. 'Darwin, Charles' result took 0.0031 seconds.

Post CID retrieval processing. No post processing query, skipping. Returned Result would be: Darwin, Charles result took 0.0074 seconds.

:-) :-) :-) Thanks lgaetz!

tm1000 commented 9 years ago

Closing this as most of it is done. New tickets can be opened if needed. Trying to clean up the mess here