search

FreeRADIUS / freeradius-client

A BSD licenced RADIUS client library
http://freeradius.org/freeradius-client/
Other
143 stars 100 forks source link

Fix size of attribute type and vendor IDs #88

Closed mcpat closed 6 years ago

mcpat commented 6 years ago

This commit fixes the representation of attribute type and vendor ID. According to RFC 2865 attribute type is one octet and vendor ID is three octets. So now, the combination of both is calculated as follows:

combined = (vendor_id << 8) | attribute_type

This commit resolves #72

alandekok commented 6 years ago

The tests fail, so those have to be fixed before the patch is added.

mcpat commented 6 years ago

Sure, as soon as somebody tells me how the tests are built and executed I can have a look into it.

mcpat commented 6 years ago

Oh I see now. The problem is, that the example dictionary file contains non-protocol attributes that "are used internally by the server". As this is the client side I will just remove them from the dictionary.