search

FreeRADIUS / freeradius-server

FreeRADIUS - A multi-protocol policy server.
http://freeradius.org
GNU General Public License v2.0
2.08k stars 1.07k forks source link

[defect]: resource leaks #4518

Closed ryancaicse closed 2 years ago

ryancaicse commented 2 years ago

What type of defect/bug is this?

incorrect 3rd party API usage

How can the issue be reproduced?

fclose(f); should be added before Line 200. https://github.com/FreeRADIUS/freeradius-server/blob/bb3d205030bd0967b67c5ef9d0dae9158c4899b7/src/modules/rlm_mruby/rlm_mruby.c#L191-L202

Log output from the FreeRADIUS daemon

None

Relevant log output from client utilities

None

Backtrace from LLDB or GDB

None
ryancaicse commented 2 years ago

Similarly, fclose(frame->fp); should be added before Line 2330. https://github.com/FreeRADIUS/freeradius-server/blob/faba86739353bae91bddc9ca20b3a773c5eb1bc2/src/lib/server/cf_file.c#L2327-L2333

alandekok commented 2 years ago

I've pushed fixes, thanks.

These issues are relatively minor, tho. While the resources "leak", these failures will both cause the server to exit, without starting up. So there's no long-term running leak.