Closed toreonify closed 4 weeks ago
Can one of the admins verify this patch?
ffs, why I even tried to accept theese suggestions from a bot. Sorry about this mess.
clang-tidy review says "All clean, LGTM! :+1:"
@freerdp-bot test
Refer to this link for build results (access rights to CI server needed): https://ci.freerdp.com//job/PullRequestTester/11911/
better than before, still much to fix though. thank you very much @toreonify
better than before, still much to fix though. thank you very much @toreonify
Thank you for taking time to review this problem. I'm glad I was helpful :)
Full description can be found in #10155.
Description
Theese fixes apply to X11 client in FreeRDP.
Context menus in some applications disappear almost instantly, cannot use them. Some application draw menus with different window flags from system context/popup menus. I've tested some combinations of flags that theese menus use. Other windows work as usual, except for dialog windows that show up as a separate window in taskbar on client side. Handling of window state flags in Windows is somewhat confusing.
Window state is not syncronized correctly with Windows side When window was maximized, then restored, then switched to another window in RDP or other X11 window, it maximized back. Maximized window state was not set on X11 window when Windows sent this event to client.
Added allowed actions for windows Client side created a X11 window without
_NET_WM_ALLOWED_ACTIONS
and allowed sending signals to maximize windows that aren't supposed to be. They can be maximized in theory, but there aren't any buttons in titlebar or in window context menu.Checks
clang-format
fixed some of the formatingscan-build
did not find any problems-pedantic
did not print warnings for changed code