FreeRDP / FreeRDP

FreeRDP is a free remote desktop protocol library and clients
http://www.freerdp.com/
Apache License 2.0
10.4k stars 14.53k forks source link

Fix popup menus and window state, add window actions (#10155) #10160

Closed toreonify closed 4 weeks ago

toreonify commented 4 weeks ago

Full description can be found in #10155.

Description

Theese fixes apply to X11 client in FreeRDP.

Checks

scan-build: Analysis run complete.
scan-build: Removing directory '/tmp/.private/builder/scan-build-2024-05-03-060319-28834-1' because it contains no reports.
scan-build: No bugs found.
freerdp-bot commented 4 weeks ago

Can one of the admins verify this patch?

toreonify commented 4 weeks ago

ffs, why I even tried to accept theese suggestions from a bot. Sorry about this mess.

github-actions[bot] commented 4 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

akallabeth commented 4 weeks ago

@freerdp-bot test

freerdp-bot commented 4 weeks ago

Refer to this link for build results (access rights to CI server needed): https://ci.freerdp.com//job/PullRequestTester/11911/

akallabeth commented 4 weeks ago

better than before, still much to fix though. thank you very much @toreonify

toreonify commented 3 weeks ago

better than before, still much to fix though. thank you very much @toreonify

Thank you for taking time to review this problem. I'm glad I was helpful :)