FreeRTOS / FreeRTOS-Cellular-Interface

FreeRTOS Cellular Interface implementation of the 3GPP TS v27.007 standard.
MIT License
85 stars 59 forks source link

[Feature Request] In-band handling of cellular_comm_interface errors #118

Open tpecar-ltek opened 1 year ago

tpecar-ltek commented 1 year ago

The cellular_comm_interface, which handles low level transfers between the modem and the cellular library, has provisions to report errors on receive / transmit (ie. caused by buffer overruns, etc.)

However, the pktio layer currently disregards this status information

https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface/blob/936d4f73b0e162912e3c41595a455319c495f90a/source/cellular_pktio.c#L590-L592

https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface/blob/936d4f73b0e162912e3c41595a455319c495f90a/source/cellular_pktio.c#L1290-L1292

It would be beneficial if the errors on the low-level layer could be propagated back to the user API.

paulbartell commented 1 year ago

Hello @tpecar-ltek. I've applied the feature request tag to this request and forwarded it to the cellular library team.

We will need to map from the CellularCommInterfaceError_t type to the CellularError_t type. Feel free to do so and open a pull request if you would like. Otherwise we will prioritize your request and add it to a future release.