FreeRTOS / FreeRTOS-Cellular-Interface

FreeRTOS Cellular Interface implementation of the 3GPP TS v27.007 standard.
MIT License
85 stars 59 forks source link

Secure Sockets Transport Implementation #146

Closed diogosilva0307 closed 8 months ago

diogosilva0307 commented 1 year ago

Description

Checklist:

Related Issue

https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface/issues/74 [Feature Request] Secure Sockets Transport Implementation By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chinglee-iot commented 1 year ago

Thank you for the PR. I will look into it and discuss with you here.

chinglee-iot commented 1 year ago

@diogosilva0307 Thank you for creating this PR. Besides BG96, we also look into other cellular modems like SARA-R4 and HL7802 specific AT commands to support secure socket connection. We would like to do the following changes base on this PR:

  1. Move Cellular_ConfigureSSLContext and Cellular_UploadFileToStorage to port specific layer APIs. The AT commands to configure SSL context and upload credentials is different for cellular modems. Therefore, we would like to move these APIs to a port specific header, for example cellular_bg96_api.h. User who wants to use secure socket connection feature will need to include the port specific header.
  2. Move CellularSocketSslConfig_t to port implementation. A pModemData pointer is defined in Cellular socket context for port to extend the socket context. In this way, modem port can define it's own socket specific data without altering the cellular interface.

The PR #147 is created with these changes. We would like to invite you to take a look and feedback in this PR.

chinglee-iot commented 8 months ago

@diogosilva0307 This PR is covered #147 We would like to close this PR due to no response in both PRs. Feel free to reopen this PRs if you have any updates.