Fix for mismatched op-types on line 3937 on tasks.c - Issue 1066

FreeRTOS / FreeRTOS-Kernel

FreeRTOS kernel files only, submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.

https://www.FreeRTOS.org

MIT License

2.51k stars 1.05k forks source link

Fix for mismatched op-types on line 3937 on tasks.c - Issue 1066 #1067

Closed markhermeling closed 1 month ago

markhermeling commented 1 month ago

Fix for MISRA C 2012 Rule 10.4 violation: Mismatched operand types, see description in #1066

Description

No code changes, added a deviation in MISRA.md and comments into tasks.c

Test Steps

No code changes

Checklist:

I did not re-run tests as there are no code changes

Related Issue

1066

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

kar-rahul-aws commented 1 month ago

Hi @markhermeling Thanks for raising the PR. Instead of suppressing the MISRA violation, we have updated the variable to BaseType_t in #1072 , which should now solve the issue.

markhermeling commented 1 month ago

I validated that the warning is gone with these changes.

kar-rahul-aws commented 1 month ago

Thanks for confirming @markhermeling . We will close this PR, since #1072 fixes the issue.