Give queue set queues a unique type number.

FreeRTOS / FreeRTOS-Kernel

FreeRTOS kernel files only, submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.

https://www.FreeRTOS.org

MIT License

2.71k stars 1.11k forks source link

Give queue set queues a unique type number. #1083

Closed schilkp closed 3 months ago

schilkp commented 3 months ago

Description

Discussed here: https://forums.freertos.org/t/tracing-improvements/20097

Changes the value of queueQUEUE_TYPE_SET to a unique value (5) to allow tracers to differentiate between normal queues and queue sets.

Test Steps

N/A

Checklist:

[X] I have tested my changes. No regression in existing tests.
[X] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

schilkp commented 3 months ago

On this note - A comment above the definition of the different queue types in queue.h states:

/* For internal use only.  These definitions *must* match those in queue.c. */

Is this still correct? Where are the definitions in queue.c that need to stay in sync? As far as I can tell, queue.c also just uses these definitions? Or am I misunderstanding something?

Thanks!

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud