FreeRTOS / FreeRTOS-Kernel

FreeRTOS kernel files only, submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.
https://www.FreeRTOS.org
MIT License
2.76k stars 1.12k forks source link

Remove Queue No Return Compilation Warnings #824

Closed Skptak closed 1 year ago

Skptak commented 1 year ago

Description

Add a return of pdFALSE to bottom of functions to remove compilation warning about no return types

Test Steps

Performed a build without the return and received this compilation warning: No return, in function returning non-void

Added the returns and now see no warnings Checklist:

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (abb5452) 93.62% compared to head (155ef84) 93.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #824 +/- ## ======================================= Coverage 93.62% 93.62% ======================================= Files 6 6 Lines 2508 2508 Branches 598 598 ======================================= Hits 2348 2348 Misses 107 107 Partials 53 53 ``` | [Flag](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/824/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/824/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | `93.62% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | Coverage Δ | | |---|---|---| | [queue.c](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS#diff-cXVldWUuYw==) | `91.91% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

RichardBarry commented 1 year ago

This change has been done before, and subsequently reverted, as it generates "code cannot be reached" warnings in some compilers. The "code cannot be reached" warning is accurate, whereas the "no return" warning isn't, hence it's preferred to go with the former.