Fix MISRA_C_2012 rule 13.2 violation

kar-rahul-aws commented 1 year ago

Fix MISRA C 2012 rule 13.2 violation

Description

Misra Rule 13.2

The value of an expression and its persistent side effects shall be the same under all permitted evaluation orders.

MISRA violation MISRA states that there shall be no more than one read access with volatile-qualified type within one sequence point. The justification for the rule is: If more than one volatile-qualified variable is read between sequence points, then it is unspecified which is read first. Reading a volatile variable is a side effect.

Fix The solution is to explicitly order the reads, using a new set of static variables.

Test Steps

N/A.

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d1a0202) 93.77% compared to head (42c7b1b) 93.77%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #855 +/- ## ======================================= Coverage 93.77% 93.77% ======================================= Files 6 6 Lines 3179 3183 +4 Branches 885 885 ======================================= + Hits 2981 2985 +4 Misses 91 91 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/855/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/855/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | `93.77% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.