FreeRTOS / FreeRTOS-Kernel

FreeRTOS kernel files only, submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.
https://www.FreeRTOS.org
MIT License
2.62k stars 1.09k forks source link

Fix build error for MSP430 and Cortex A with IAR #937

Closed jefftenney closed 8 months ago

jefftenney commented 8 months ago

Description

Fix a build error in the MSP430 and Cortex A IAR ports caused by whitespace missing in asm macros. Add whitespace to make sure all instruction mnemonics and assembler directives do not appear in the label field (column 1) of the line.

Test Steps

Build the msp430_IAR demo with and without this PR. When building without this PR, the assembler gives the error "Error[14]: Missing #endif" for both serialASM.s43 and portext.s43. When building with this PR, no error.

Note I did not test the Cortex A ports. I don't have the IAR compiler/assembler for Cortex A.

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jefftenney commented 8 months ago

For perspective, #768 introduced the whitespace issue being fixed in this PR. Most of the other issues caused by #768 have already been resolved. However, these two files have similar issues not yet resolved:

https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/V11.0.1/portable/IAR/ARM_CA9/portASM.h https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/V11.0.1/portable/IAR/ARM_CA5_No_GIC/portASM.h

I did not include those two files in this PR because I don't have the IAR Cortex A compiler. Do you want me to revert those files in this PR even though I won't be able to test? EDIT: I went ahead and did a revert of those two files to pre #768.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (58f0d36) 93.78% compared to head (1a889a9) 93.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #937 +/- ## ======================================= Coverage 93.78% 93.78% ======================================= Files 6 6 Lines 3186 3186 Branches 885 885 ======================================= Hits 2988 2988 Misses 91 91 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | `93.78% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AniruddhaKanhere commented 8 months ago

Thank you @jefftenney for taking the time to fix this port's files! Much appreciated.

Since it has the required approvals, I shall merge this PR now.