Fix MISRA C 2012 Rule 14.4 Violations.

bradleysmith23 commented 5 months ago

Description

MISRA rule 14.4 - The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially boolean type.

macro listLIST_IS_EMPTY() returns pdTrue or pdFalse which are not of the essentially bool type (_Bool). By comparing the value it returns against 0, the expression evaluates to essentially boolean type.

Test Steps

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4da9e3) 93.65% compared to head (c70a4ae) 93.62%. Report is 2 commits behind head on main.

Files	Patch %	Lines
tasks.c	80.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #975 +/- ## ========================================== - Coverage 93.65% 93.62% -0.03% ========================================== Files 6 6 Lines 3198 3199 +1 Branches 886 886 ========================================== Hits 2995 2995 - Misses 91 92 +1 Partials 112 112 ``` | [Flag](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/975/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/FreeRTOS/FreeRTOS-Kernel/pull/975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS) | `93.62% <80.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FreeRTOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bradleysmith23 commented 5 months ago

/bot run formatting