FreeRTOS / FreeRTOS-Plus-TCP

FreeRTOS-Plus-TCP library repository. +TCP files only. Submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.
MIT License
152 stars 163 forks source link

Build separation for ARP/ND #1092

Closed HTRamsey closed 7 months ago

HTRamsey commented 9 months ago

Improve Build separation for IPv4/IPv6

Description

Only include FreeRTOS_ARP if IPv4 is enabled. Move everything else into routing which calls either ARP or ND. Also create a frame agnostic helper for checking the cache.

Test Steps

Need to finish adjusting a couple tests

Checklist:

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

paulbartell commented 9 months ago

Thanks for the PR. Looks like there are a few formatting and other CI checks that need to be addressed. I'll make sure to send this to the team for review as well.

paulbartell commented 9 months ago

/bot run formatting

HTRamsey commented 9 months ago

@tony-josi-aws I noticed some issues with ARP/ND in this and I started to fix them but didn't want to lose focus of the point of this PR. I'll make a separate PR for that.

HTRamsey commented 9 months ago

@tony-josi-aws Also parts of xCheckRequiresResolution and xStartAddressResolution are currently redundant so I need to reconcile duplicate functionality as well. I'll save any functionality changes for a different PR so that this mostly just helps build separation. The other issues I mentioned are things like unsolicited solicitations not working as expected, as FreeRTOS_OutputAdvertiseIPv6 is called in the gratuitous arp code which is triggered in DHCPv4. Also it always sets the ndICMPv6_FLAG_SOLICITED flag. vARPAgeCache and sending gratuitous arps need to be decoupled as well.

HTRamsey commented 9 months ago

/bot run formatting

HTRamsey commented 9 months ago

/bot run formatting

HTRamsey commented 9 months ago

@tony-josi-aws I went back one more time to make it simpler and less to review

HTRamsey commented 9 months ago

/bot run formatting