search

FreeRTOS / FreeRTOS-Plus-TCP

FreeRTOS-Plus-TCP library repository. +TCP files only. Submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.
MIT License
152 stars 163 forks source link

Remove macros ipLOCAL_MAC_ADDRESS and ipLOCAL_IP_ADDRESS_POINTER #1097

Closed HTRamsey closed 8 months ago

HTRamsey commented 9 months ago

Remove Old Incompatible Code

Description

Looks like these are left over from before multiple endpoints were added, and it no longer works in any useful manner. It also helps resolve some of the linkage issues I kept having in tests due to dependencies causing multiple definitions of xDefaultPartUDPPacketHeader. The UDP files shouldn't be required by everything else anymore.

Test Steps

Checklist:

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

HTRamsey commented 9 months ago

/bot run formatting

HTRamsey commented 9 months ago

@tony-josi-aws I assume that one failure had nothing to do with the code right?

tony-josi-aws commented 9 months ago

@tony-josi-aws I assume that one failure had nothing to do with the code right?

@HTRamsey, no, its just that the GCC website link was unreachable when the check was done. Triggered a re-run.

moninom1 commented 8 months ago

Seems like there are a lot of UT conflicts, @HTRamsey will you please help in taking a look. Thank you

shubnil commented 8 months ago

If the definition inside the function is to restrict the scope, then I am good as long as Misra does not give any warnings.