search

FreeRTOS / FreeRTOS-Plus-TCP

FreeRTOS-Plus-TCP library repository. +TCP files only. Submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.
MIT License
125 stars 149 forks source link

ipconfigCOMPATIBLE_WITH_SINGLE & ipconfigIPv4_BACKWARD_COMPATIBLE are used inconsistently #1133

Closed HTRamsey closed 2 months ago

HTRamsey commented 3 months ago

I assume ipconfigIPv4_BACKWARD_COMPATIBLE is for just IPv4/IPv6 & ipconfigCOMPATIBLE_WITH_SINGLE is only relevant for FreeRTOS_Routing.c. However, some Network Interfaces use ipconfigIPv4_BACKWARD_COMPATIBLE and others use ipconfigCOMPATIBLE_WITH_SINGLE when guarding pxFillInterfaceDescriptor.

Skptak commented 3 months ago

I believe ipconfigCOMPATIBLE_WITH_SINGLE is supposed to be a different config for when only allowing a single network interface. I believe the idea is that this is separate from the changes involved in ipconfigIPv4_BACKWARD_COMPATIBLE at certain places. @htibosch or @tony-josi-aws may have more accurate information.

HTRamsey commented 3 months ago

Here is an example of what I am referring to: NXP1060 STM32Hxx

Edit: Unrelated but that NXP1060 function doesn't return anything

tony-josi-aws commented 2 months ago

Created a PR #1134 to fix the issue