[BUG]Missing parameters and undefined macros

FreeRTOS / FreeRTOS-Plus-TCP

FreeRTOS-Plus-TCP library repository. +TCP files only. Submoduled into https://github.com/FreeRTOS/FreeRTOS and various other repos.

MIT License

149 stars 159 forks source link

[BUG]Missing parameters and undefined macros #1190

Closed lightning51522 closed 3 weeks ago

lightning51522 commented 1 month ago

I am currently porting TCP packets of version 4.2.2 Release. On ATSAM4E, I have found issues with missing parameters when calling functions in the network interface source file, as well as the use of an undefined macro。

1.The function usGeneratedProtocolChecksum called in line 422 of the portable/NetworkInterface/ATSAM4E/NetworkInterface. c file is missing a length parameter. 2.The macro ipLOCAL_MAC_ADDRESS used on line 315 of the same file has not been defined.

Hope these errors can be fixed

kar-rahul-aws commented 1 month ago

Hi @lightning51522 I have raised a PR for fixing the missing parameter issue in ATSAM4E port. Thanks for pointing out the issue. Regarding your other concern, DriverSAM replaces the older ATSAM4E port. So, you can use this port in your project . You can take a look at this PR , and make similar changes to the ATSAM4E port and raise a PR. We will be happy to review it.

Thanks.

jasonpcarroll commented 4 weeks ago

Can this issue be closed?

kar-rahul-aws commented 3 weeks ago

Closing this issue since the [PR] (https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/pull/1192) has been merged. Please reopen this issue if you feel otherwise.