search

FreeTAKTeam / FreeTAKHub-Installation

FreeTAKHub-Installation
Eclipse Public License 2.0
33 stars 29 forks source link

Installation on unsupported Ubuntu 24.04 cannot proceed because the question is suppressed #126

Open jakobbuis opened 2 weeks ago

jakobbuis commented 2 weeks ago

Steps to reproduce

  1. Create an Ubuntu 24.04 machine
  2. Run the easy installer script: wget -qO - bit.ly/freetakhub2 | sudo bash -s

Expected: Output a warning with the option to proceed, waiting for the user to override: 

Checking for supported OS...WARNING
FreeTAKServer has only been tested on \033[0;32mUbuntu 22.04\033[0m.
This machine is currently running: Ubuntu 24.04
Errors may arise during installation or execution.
Do you want to continue? [y/n]: y
Proceeding...

Happened: The user cannot answer the question as the following is output immediately: 

Checking for supported OS...WARNING
FreeTAKServer has only been tested on \033[0;32mUbuntu 22.04\033[0m.
This machine is currently running: Ubuntu 24.04
Errors may arise during installation or execution.
Answer was not y. Not proceeding.
Exiting. Installation NOT successful.

This happens because in easy_install.sh on line 14 the terminal is set to non-interactive, so the terminal doesn't wait for the user to input 'y' and immediately proceeds.

Note that I'm not saying that you should be supporting Ubuntu 24.04, just that your input handling is broken, I'm not creating a PR at this time because I'm not sure why line 14 is there in the first place, considering Chesterton's fence