search

FreeTAKTeam / FreeTakServer

Situational Awareness Server compatible with TAK clients
Eclipse Public License 2.0
681 stars 170 forks source link

Protobuff #243

Open brothercorvo opened 2 years ago

brothercorvo commented 2 years ago

this is to implement a Protobuff over TCP communication between a TAK client and FTS.

brothercorvo commented 11 months ago

related to services @naman108 ?

naman108 commented 11 months ago

I don't think this should be closed as we still want to implement protobuf @brothercorvo

naman108 commented 8 months ago

This issue has several dimensions. First of all, protobuf in python requires the generation of protobuf domain files, this would be a useful application of the generation work. Secondly protobuf would probably require the implementation of a new serialization controller in the DigitalPy serialization component. Finally theres the question of latency as we found in past experiments that the python implementation protobuf is extremely slow.

brothercorvo commented 8 months ago

Python speed is a concern but the real conceptual issue here is that switching protocol over the same port is an anti pattern, typically you would go to a completely different port. If we implement that we break our network/service implementation

naman108 commented 8 months ago

Python speed is a concern but the real conceptual issue here is that switching protocol over the same port is an anti pattern, typically you would go to a completely different port. If we implement that we break our network/service implementation

Yes, that is another issue. Though neither the network, nor the service is responsible for the serialization process.