search

FreeTAKTeam / UI

FreeTAKServer Web User Interface project
MIT License
30 stars 27 forks source link

Updated `config.py` more platform independent (Win32) #53

Open phreed opened 7 months ago

phreed commented 7 months ago

Issues to discuss:

Use of platformdirs

platformdirs makes some decisions that differ from those in the config.py. https://platformdirs.readthedocs.io/en/latest/

Use of sysconfig

sysconfig can be used to identify the site-packages (or equivalent). The use of MAIN_PATH = Path(sysconfig.get_path('purelib')) may be more reliable; than, searching based on knowing the location of __file__.

Using python Paths rather than strings

The place where this is most likely is config.py. Are there other source files that should be considered?

brothercorvo commented 7 months ago

we need to extensive test this. In general we want to host all user configurations in the YAML file. see the priorty of configuration image

phreed commented 7 months ago

we need to extensive test this. In general we want to host all user configurations in the YAML file. see the priorty of configuration

Yes indeed. I see FTSConfig.yaml as used in development. I see in FTS Docs the two files described being edited to configure FTS are <site-packages>/FreeTAKServer-UI/config.py and <site-packages>/FreeTAKServer/controllers/configuration/MainConfig.py.

Those files are:

Is it appropriate for these documents to recommend modifying config.py?

brothercorvo commented 5 months ago

@naman108 please review this and see if we can approve

brothercorvo commented 4 months ago

@naman108 ping