search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

Add Reload button #1005

Open Iusy opened 3 years ago

Iusy commented 3 years ago

I think a reload button is a basic functionality , but very much needed. I looked everywhere and there isn't a way to manually reload the curent video. I think the best location for the reload button is at the top of the page, as on every browser, next to the previous/next arrows.

saideepesh000 commented 3 years ago

Hey @Iusy , thanks for pointing out, until it's implemented, you can use ctrl+r, but this reloads the entire app.

PikachuEXE commented 3 years ago

1223 opened

PikachuEXE commented 3 years ago

After reading a review comment for #1223 Now I don't understand the meaning of "reloading the current video"

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 years ago

@PikachuEXE maybe issue #1500 helps u out.

ghost commented 3 years ago

IMHO, adding a refresh button is just hiding existing problems and it starts to become a 'YouTube web browser'... Is there not just a 'replay' or restart button?

I have posted a comment about this on related thread: https://github.com/FreeTubeApp/FreeTube/pull/1223#issuecomment-874865868

kommunarr commented 3 years ago

Continuing the discussion under #1223:

Or, as a last resort, initiate the reload routine when this error occurs, with a counter so after 3 tries it can fail with an error?

I think this is a good idea, but auto-reloading is a bit jarring to the user IMO, and it might be irksome if it's a client-side issue they're working on (e.g., they turned off their Internet connection). One possibility might be to add a polite "An error occurred. Click here to reload the video" alert that appears upon the detection of an error that impedes the video player.

IMHO a 'reload button' feels like a bit of a workaround for some unresolved problems laying beneath. In the same way that turning it off and back on is not actually a solution.

This is technically correct, but I would argue that this rationale leans on the nirvana fallacy. There will always be new bugs popping up, bugs that can't be fixed easily, errors that can't be detected easily, upstream bugs outside of our direct purview, and bugs that most users won't see fixed until the next official release. They're not app-breaking bugs, but they are infrequent & inevitable occurrences that can degrade user experience. For example, sometimes I pull up a video on FT, and it takes forever to load. The bug doesn't show up as a detectable error, and the problem usually goes away after reloading the video. Maybe there's an upstream fix being worked on, maybe the upstream fix is out but just not yet merged into FT, maybe I should just work on solving it myself because open source ideology etc etc, but realistically I'm just going to be annoyed as a user.

I still think a reload button is an important utility, and I would be glad to implement it if @PikachuEXE does not want to continue with their attempt.

PikachuEXE commented 3 years ago

I am actually still confused on what the reload button should do @jasonhenriquez Please implement, don't mind me

aleksejrs commented 1 year ago

Ctrl + R changes the title of the current window momentarily, but does not change the title or contents of the other window. So it does not actually reload the entire app? Then, while not the button, the action itself is in place, but it is not documented properly.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Ctrl + R changes the title of the current window momentarily, but does not change the title or contents of the other window. So it does not actually reload the entire app?

It only reloads the current window.

lonix1 commented 1 year ago

Since my dupe issue https://github.com/FreeTubeApp/FreeTube/issues/4062 was closed: an important part of the reload, is not to disrupt the playlist's order or settings.

GangstaPichu commented 1 year ago

I would love this as a feature. A little reload button somewhere next to the FreeTube logo or something. I'm saddened it isn't a thing yet. I hate losing the video I was watching if I'm going down a channel with their being series of stuff after it sitting over night or a bit cause I ended up falling asleep or got busy with something. Would be a nice quality touch to have.

d3al commented 1 year ago

New freetube user and I hit this issue often. My use case is to have multiple windows open with a video I want to watch lined up and I commonly starting watching something, pause and come back to it later and video breaks due to inactivity. No way to reload the current video and there is no URL to the video I'm watching so I can copy/paste into a new window to start watching again. I've basically lost the video and need to hunt down the channel by name and this is soul crushing after it happening a few times.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

@d3al try ctrl + r

d3al commented 12 months ago

That worked, thank you.

On Sun, 2023-10-22 at 00:26 -0700, efb4f5ff-1298-471a-8973-3d47447115dc wrote:

@d3al try ctrl + r — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

omgUFOs commented 5 months ago

Dear Devs, I need this in my life, because my hands don't work very well to CTRL+R. It causes me pain...

Thank you :)