FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

Add a setting to change emotes size #1116

Open Trung0246 opened 3 years ago

Trung0246 commented 3 years ago

Behavior of the program: The emote size should be small enough with text size in the live chat. Instead it display the full size.

Expected behavior: Emote size should be about the same (or maybe configurable emote size) with the text size.

To Reproduce: Open any live stream that have custom emotes and see the chat spamming sub emotes.

Screenshots: In FreeTube: image In Youtube: image

Environment Information (please complete the following information):

GilgusMaximus commented 3 years ago

So I fixed that in theory. However with a pixel size of 16x16 it is rather small and I personally cannot identify the emote anymore. Therefore here are some sizes I tested:

16x16 image

24x24 image

28x28 image

32x32 image

So some feedback would be appreciated before I merge this.

Trung0246 commented 3 years ago

28 is the best for me honestly. But 32 looks crisp enough but still kinda too big. However emotes size are subjective, so I've suggest to add a setting to set emote size. Probably the emotes should be centered like in Youtube (instead of emotes being aligned at the bottom like in FreeTube). If anyone else have any ideas could be good.

GilgusMaximus commented 3 years ago

Well making this a setting is the best idea, however I will leave this for another person or for later, as this is not really a priority setting at the moment. So I am going to merge my code for the moment, but either you could open a new issue for a setting request or we can convert this issue into one

Trung0246 commented 3 years ago

+1 for converting this issue into feature settings request (enhancement label?)