search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.66k stars 864 forks source link

Limit resolution to what what is actually displayed #1129

Closed chaptergy closed 2 months ago

chaptergy commented 3 years ago

Is your feature request related to a usage problem (not a bug)? Please describe. I was having the issue that some videos were buffering all the time, while most just work fine. I found, that FreeTube always tries to play at the highest resolution (as described in issue https://github.com/FreeTubeApp/FreeTube/issues/595), so it was loading 4K video when I am watching on a 1080p screen not even in fullscreen.

Describe the solution you'd like to see implemented Limit the resolution to what can actually be displayed on screen. so if the video on screen will show in an area of maybe 680x1000px, it should go no further than the 720p stream.

Describe alternatives you've considered Add a maximum resolution to the settings. This way I can at least say to use 1080p max, since I have no screens with a greater resolution than full HD.

Additional context Of course this would only be possible if actual control over the resolution is possible, but the comments in the issue linked above give me hope this is possible in the future.

GilgusMaximus commented 3 years ago

We deliberately deactivated that feature. Although it didn't stop displaying larger resolutions while it was deactivated either.

But it should be possible to add a settings option for that. Although fixing #595 will probably already be enough then

ghost commented 3 years ago

Describe the solution you'd like to see implemented Limit the resolution to what can actually be displayed on screen. so if the video on screen will show in an area of maybe 680x1000px, it should go no further than the 720p stream.

Describe alternatives you've considered Add a maximum resolution to the settings. This way I can at least say to use 1080p max, since I have no screens with a greater resolution than full HD.

You may well be creating another problem, whereby the software needs to reliably and consistently detect screen resolutions and I have multiple screens... How would that work on my set-up?

One is 1440x900 and the big one is 1920x1080p - What would your player do on my machine and how reliable would it need to be?? O_o

I think this would be a step in the wrong direction.

IMHO, it would be better (and more intuitive) to stick to displaying the available qualities in the video player quality list and honouring the Default Quality setting, which you can set for your main playback screen(s).

I would, however, like to see different resolution selections for small/page and full-screen players. Ie, I could choose 360p for windowed playback and 1080p for full-screen playback - Like the YouTube Enhancer plug-in ;)

Any thoughts? Have I completely missed the point?

GilgusMaximus commented 3 years ago

You can get all screens via Electron an then just take the largest in terms of width. This way it is safe to say that the app covers all possible resolutions available.

But as this has been stale and not really on any priority list, do not fear that this will come quickly. Additionally I also have a second monitor to work with