FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.38k stars 825 forks source link

Suggestion for a "Find in Page" feature to easily search through comments #1401

Open RagglenLove opened 3 years ago

RagglenLove commented 3 years ago

Important note Please check other open and closed issues for a similar feature request before proposing a new one. Also please leave all headers except this one in the issue, so that it is clear what belongs where.

Is your feature request related to a usage problem (not a bug)? Please describe. When I'm going through the comments of a video, I get tired reading through so many comments, so I'd like for a "Find in Page" feature to easily search through comments.

Describe the solution you'd like to see implemented On Firefox, when browsing YouTube, one could easily search for a keyword in the comments by pressing Ctrl+F. I'm suggestion for a feature similar to this on FreeTube.

Describe alternatives you've considered

Screenshots

Additional context

RagglenLove commented 3 years ago

Here's a mock-up I've created to show the feature that I'm suggesting: Screenshot_2021-06-13_09-15-15

ChunkyProgrammer commented 3 years ago

I'm not super familiar with Electron/vue.js but this might be useful for whoever works on this? https://www.electronjs.org/docs/api/web-contents#contentsfindinpagetext-options

webContents.on('found-in-page', (event, result) => {
  if (result.finalUpdate) webContents.stopFindInPage('clearSelection')
})

const requestId = webContents.findInPage('api')
console.log(requestId)
kommunarr commented 1 year ago

Boosting this issue, as this seems to be a reasonably in-demand feature that other folks and even myself keep wanting to have.

kommunarr commented 1 year ago

FYI, I did some work on this a couple of weeks ago, but wasn't able to find a resolution to the focus being lost on findInPage. Here's what I have so far if someone is interested in taking up the mantle.

BloodRaven0 commented 9 months ago

+1, great feature idea, but there might be a better way to implement this. In browsers "Find in Page" only searches text in comments that you have already loaded and sometimes finds matches in unopened reply trees, or in suggested videos in the sidebar, making it a janky and non-ideal solution.

Because FreeTube is its own program, we can implement it in a more intelligent way - put a search bar next to the "Comments" header that would automatically search only the comments (and replies), and filter out the ones that don't have any matches in them. It would also automatically load more comments, and filter them as well, so you get a list of comments only containing the keyword you're searching for, making scrolling through all comments while searching for matches unnecessary.

weltivambian commented 9 months ago

Would like this too. Sometimes I want to search a specific playlist of a channel and some channels have very many playlists... A regular text search like in a browser would be great.

secure-username commented 4 weeks ago

I would rather have a "find in page" option that searches all text on the page, rather than just comments. I frequently find myself trying to ctrl-f on channel pages to search for videos, or to look for keywords in descriptions.