FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

Display time in days if video is longer then a 24hrs #1471

Open efb4f5ff-1298-471a-8973-3d47447115dc opened 3 years ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 years ago

Is your feature request related to a usage problem (not a bug)? Please describe. Time is currently displayed only in hours but it would be nice to also have it in days if the video is longer then 24hrs.

Describe the solution you'd like to see implemented Display the time in days if the video is longer then 24hrs.

Describe alternatives you've considered None.

Screenshots https://youtu.be/EuyLTxHSUvM

Freetube: Ca1pture

Alternative: Capture

Additional context None.

peepo5 commented 3 years ago

This is not really needed, showing days would break the format

would you say like 1.5 days?

it would be hard to determine specific times then.

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 years ago

Umm im not sure how the time is implemented at the moment. If it would be something like 1.5days then i would say to not implement this because it would only complicate the code.

arrowgent commented 3 years ago

is there a specification by youtube for time formatting? or media in general? can you provide examples of regional settings where formatting changes to include Days? can you provide examples in Media Players that convert formatting to Days?

i see no issue with time being displayed by hours:minutes:seconds instead of days:hours:minutes:seconds

this could break description/comment time formatting also if someone posts a timeskip 24:00:01 in description then freetube would have to interpret that

as a standard, youtube only holds videos publically that are 12 hours or less, so 24+ hour videos would mostly be Moot unless otherwise hacked, legacy, or special use case. exceptions being LiveStreams, but those you cannot skip around in for extended periods?

i dont see the benefit for changing/adding this feature to create a Days timestamp system

it would make the standard of knowing that there are 60 minutes in an hour and 60 seconds in a minute and reading time in general too complicated

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 years ago

Ah i didn't know that it would break other things like comments as well. If that is really the case i think it will better if this is a wont implement.

peepo5 commented 3 years ago

maybe the visual output could be 1D:12H:0M:0S to make interpreting easier but i am not sure if this is consistent. also would only be visual not functional output

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.