FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.59k stars 852 forks source link

Add 600% Sound Volume-like functionality to FreeTube #1551

Closed RagglenLove closed 4 days ago

RagglenLove commented 3 years ago

Is your feature request related to a usage problem (not a bug)? Please describe. Sometimes, content creators on YouTube upload videos where the volume is too low. One such example is this video: https://www.youtube.com/watch?v=sRaXqaji8Ag.

Describe the solution you'd like to see implemented I’d like to see SoundFixer-like functionality added to FreeTube. SoundFixer is a Firefox addon that allows you to increase the volume of a YouTube video past 100%, it is useful for videos where the volume is too low. Here’s the link to the addon: https://addons.mozilla.org/en-US/firefox/addon/soundfixer/

Screenshots Screenshot_2021-07-28_18-53-15 Screenshot of SoundFixer's interface.

GilgusMaximus commented 3 years ago

But you could also increase the volume of Freetube in the sound mixer of your OS and leave every other app as is. Wouldn't that solve the problem?

RagglenLove commented 3 years ago

But you could also increase the volume of Freetube in the sound mixer of your OS and leave every other app as is. Wouldn't that solve the problem?

Yes, but I have encountered issues with using my OS's sound mixer when I tried to increase the volume of a YouTube video on Firefox, if you pause or forward the video, the volume goes back to it's default low volume, which is why I installed SoundFixer to begin with.

Also, SoundFixer works on a per-window or tab basis, so for example, if you are playing two videos in different windows or tabs, one with low volume and one with normal volume, switching in between the two videos, using my OS's sound mixer makes the video with the normal volume very loud, so using SoundFixer fixes this issue.

GilgusMaximus commented 3 years ago

Okay, but that is an issue with your operating system. I am not too sure this would be very helpful for many people. You could also use something like VLC as external player and have it's audio features, effects and more available

NineXYZ commented 3 years ago

For me this makes sense... Using VLC is too complicated for only increasing the volume and at least in macOS there isn't a per app volume setting.

RagglenLove commented 3 years ago

Found a better alternative to SoundFixer, it's called 600% Sound Volume. Here's the link to the addon: https://addons.mozilla.org/en-US/firefox/addon/600-sound-volume/

Screenshot_2021-08-21_09-26-28 Here's the inferface.

For me this makes sense... Using VLC is too complicated for only increasing the volume and at least in macOS there isn't a per app volume setting.

I agree, FreeTube should natively have this kind of functionality, why make a user use something else? It seems counterintuitive to me and also, it makes FreeTube user friendly to un-technical people who may not know how to use their OS's sound mixer or VLC.

arrowgent commented 3 years ago

i agree here, id love a secondary GAIN booster to over 100% my audio

LINUX already i have system audio set to 100% in MPV i set my max to 150%, 100% being ideal, higher is a gain above normal and only needed rarely. many many many videos on FreeTube are quiet by comparison to 100% in MPV or in chromium

so id love a tool or feature built into Freetube to handle toggling higher audio output volume

maybe for comparison someone could look at open source GPL of VLC & MPV to see how they handle it?

mxvin commented 2 years ago

I propose changes on https://github.com/FreeTubeApp/FreeTube/blob/2be2301d92e37d13a4839ded1fc436836292b7d4/src/renderer/components/ft-video-player/ft-video-player.js#L1029-L1040

Or, A Quick way, just make another button and slider outside videojs, and hook that to "gain volume" function independently.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 weeks ago

In v0.22.0 we have introduced support for YouTube's Stable Volume feature on the Local API. You can find this setting in the video player

Are the videos that were perceived as too quiet okay when you turn this setting on like this:

https://github.com/user-attachments/assets/aa99b494-c114-4715-9c21-c4444f02bcc1

tintin67 commented 1 week ago

Compared to Minitube Freetube audio volume is definitely lower after trying several videos to test this, original or stable volume didn't make any difference. If Minitube can do this., this could be an added functionality in a Freetube future update ?

github-actions[bot] commented 4 days ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.