FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

Middle click to "autoscroll" #1847

Open loveisfoss opened 3 years ago

loveisfoss commented 3 years ago

Is your feature request related to a usage problem (not a bug)? Please describe. Not really a problem but a feature request.

Describe the solution you'd like to see implemented I thought that it would be useful to be able to scroll up and down by middle clicking the mouse. This feature is called "autoscroll" in firefox.

Describe alternatives you've considered Not other alternatives.

Screenshots This is an example on how it looks like on firefox. Screenshot from 2021-10-21 22-40-53

Additional context Not any.

absidue commented 2 years ago

This is working on 0.16.0 on Windows 10. @loveisfoss Please check if it works for you, if it does this can be closed.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 years ago

this issue will automatically after close 21 days if there will be no response from the author

loveisfoss commented 2 years ago

This is working on 0.16.0 on Windows 10. @loveisfoss Please check if it works for you, if it does this can be closed.

I have just checked on Linux (Debian bookworm, FreeTube 0.16.0) and autoscroll is not being triggered when middle clicking. So, I guess this issue is still relevant?

Just for reference, when middle clicking link texts, they open in a new tab on the systems default browser.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 years ago

This is working on 0.16.0 on Windows 10. @loveisfoss Please check if it works for you, if it does this can be closed.

I have just checked on Linux (Debian bookworm, FreeTube 0.16.0) and autoscroll is not being triggered when middle clicking. So, I guess this issue is still relevant?

Just for reference, when middle clicking link texts, they open in a new tab on the systems default browser.

Could u try out the latest nightly build and report back.

loveisfoss commented 2 years ago

Uhm, just installed nightly 1630 and 1633 and autoscroll is not triggered when middle clicking in any menu.

absidue commented 2 years ago

Okay so i've done some research and it looks like the chromium team is refusing to implement auto scroll on linux as the default behaviour of the middle mouse button on linux is to paste the clipboard. This leaves use with two solutions:

  1. The easy one is for the user to change the behaviour of the middle mouse button system wide with libinput (see: https://unix.stackexchange.com/a/421672)
  2. The other option is to implement a fully custom version of auto scrolling inside FreeTube that will only be used on Linux. This will likely be a lot of work to do.
loveisfoss commented 2 years ago

Okay so i've done some research and it looks like the chromium team is refusing to implement auto scroll on linux as the default behaviour of the middle mouse button on linux is to paste the clipboard. This leaves use with two solutions:

1. The easy one is for the user to change the behaviour of the middle mouse button system wide with libinput (see: https://unix.stackexchange.com/a/421672)

2. The other option is to implement a fully custom version of auto scrolling inside FreeTube that will only be used on Linux. This will likely be a lot of work to do.

Now, when you mention it, I remember having to install a browser extension in order to use this function in chrome based browsers. So, since this is a limitation of using electron (chromium) and also option 2 would need a lot of work to be implemented, I would say that we can live without autoscroll, at least for now. What say you?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.