[MacOS] Extended shortcuts

[lothar-cell]

Is your feature request related to a usage problem (not a bug)? Please describe. More shortcuts would be great, because shortcuts are a good thing.

Describe the solution you'd like to see implemented Would be great if commands like:

• New Page (⌘N)
• New Tab (⌘T)
• Show Previous/Next Tab
• Settings (⌘,)
• History (⌘Y)
• Home
• Back, Forward
• Subscriptions
• Playlists
• Switch Channel

and so on would be implemented, they would be menu titles, so they could be customised in OS settings as well.

Screenshots

Shortcut customisation in OS, needs a menu title:

Additional context no additional context.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Duplicate of https://github.com/FreeTubeApp/FreeTube/issues/251

[lothar-cell]

Actually it's not a duplicate of #251, but a completely different issue. This one is about extending the menu items, which can use the native MacOS shortcut system. See screenshots.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I'll let @PikachuEXE decide if this is worth reopening.

[PikachuEXE]

I think this is a valid issue and not a dupe to #251. However I have no idea how "menu titles" can be implemented.

[lothar-cell]

Template updated, I think it was completely unnecessary, but hopefully @efb4f5ff-1298-471a-8973-3d47447115dc will be satisfied and U: doesn't follow template can be removed.

[lothar-cell]

However I have no idea how "menu titles" can be implemented.

Maybe this can be of help? https://stackoverflow.com/questions/38208469/electron-osx-application-menu-how-to-add-custom-file-menu

[PikachuEXE]

Create first PR for this: https://github.com/FreeTubeApp/FreeTube/pull/2306

[PikachuEXE]

@lothar-cell What is Switch Channel? Do you mean Channels?

Do you also want Trending, Most Popular, what else...

Edit 1: Just realize Home should be the same as Subscriptions

[lothar-cell]

@PikachuEXE Yes, I meant switching YouTube Channels, but also switching between Profiles would be nice. About Trending, Most Popular and Subscriptions, I think the best would be to have an option in settings for choosing what to assign Home to, like in case of Invidious or Piped.

[absidue]

Changing between subscribed channels is not possible to implement, as the top menu is app-wide in Electron, which means it's the same one across all windows. As FreeTube lets you have different profiles active in different windows, you would need different menus for every window for that to work, but that is something that Electron doesn't support.

[PikachuEXE]

@absidue I think that point is invalid for "switching profiles" (ya I know he said Switch Channel but I think he meant profile) If you open multiple windows and use one of the menu items on top, the page will only be changed for the "active window"

See linked PRs for code and see following doc for browser window https://www.electronjs.org/docs/latest/api/menu-item

I only think change for switching profile in menu item might not accepted coz there can be many profiles https://github.com/FreeTubeApp/FreeTube/pull/2965#issuecomment-1809672572

[lothar-cell]

Actually by Switching Channels I meant a shortcut for cycling them, but that was when I had fewer subscriptions. Nevertheless the same thing would even be better for Profiles IMO. My reason is that the only profile I'm using currently is All Channels, because it's not intuitive switch between them, even though it's a really good idea for organising content. Apart from a shortcut of some sort (cycling / bringing up the profile switcher window / individual shortcuts), an option for setting default profile when launching FreeTube, would help to make it more user-friendly.