FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.08k stars 810 forks source link

[Bug]: Disable horizontal scrollbar and make the UI fit to screen in portrait mode #2230

Open bigbiggie opened 2 years ago

bigbiggie commented 2 years ago

Guidelines

Describe the bug

On most videos the UI looks good, but when there is a large link or a large word without spaces (for example a bitcoin address) in the description, the UI of FreeTube will create horizontal scrollbars and it is not possible to watch the video anymore. See pictures 20220501_20h40m58s_grim 20220501_20h41m40s_grim 20220501_20h41m59s_grim .

Expected Behavior

The video player should always fit into the window.

Issue Labels

visual bug

FreeTube Version

v0.16.0 Beta

Operating System Version

Arch Linux Arm

Installation Method (If applicable)

Flathub

Last Known Working FreeTube Version (If Any)

No response

Primary API used

No response

Additional Information

No response

Nightly Build

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

ceeb9 commented 1 year ago

what's the aspect ratio of your device?

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

@MarmadileManteater im not able test but was this fixed by ur latest PR?

bigbiggie commented 1 year ago

what's the aspect ratio of your device?

It's a pinephone (5.95'', 1440x720)

@MarmadileManteater im not able test but was this fixed by ur latest PR?

It's mostly fixed. The horizontal scrollbar still appears sometimes, when reading comments (i.e. when showing replies of a comment). It doesn't seem to happen on all videos, no idea why. On the video in the second picture (v=zrProK5R7ms), this bug can be reproduced by showing the comments, viewing the replies of the pinned comment, scrolling down, and then clicking on show more replies.

MarmadileManteater commented 1 year ago

I've noticed that long channel names with no spaces in them tend to cause the page to overflow. They can be anywhere on the page. Sometimes, they are in the related videos section, but they aren't always. I could imagine that comment replies are probably more prone to this issue since they provide less space for the channel name to appear than top level comments.

A fix for this might be to change the word-wrap styling on channel names to break-word.

MarmadileManteater commented 1 year ago

Also, buttons sometimes cause the page to overflow because they don't word wrap. This isn't a problem if the locale is set to English. image

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.