FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Bug]: search `#shorts` in searchbar results in `TypeError: Cannot read properties of undefined (reading 'url')` #2385

Closed efb4f5ff-1298-471a-8973-3d47447115dc closed 1 year ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 years ago

Guidelines

Describe the bug

  1. Search #shorts
  2. see error

Expected Behavior

no error

Issue Labels

API issue, text/string issue

FreeTube Version

https://github.com/FreeTubeApp/FreeTube/commit/04c276ca73a62db8c9ecdeddc38b9acbf0c469e9

Operating System Version

win10 21h2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

absidue commented 2 years ago

Looks like @ChunkyProgrammer opened a PR https://github.com/TimeForANinja/node-ytsr/pull/164 to fix that in the ytsr repo a while ago, it might make sense to make FreeTube use the branch in that PR as upstream hasn't merged the PR yet.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 years ago

Noticed that now anything with a # in the search query will give u this error

Try searching

  1. anything

  2. ltt

ChunkyProgrammer commented 2 years ago

We could switch to my branch for the search module (my pr got closed due to inactivity)

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.