FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.53k stars 842 forks source link

[Feature Request]: Separate language settings – application language and preferred video title language #2590

Open kmaterzok opened 2 years ago

kmaterzok commented 2 years ago

Guidelines

Problem Description

Some videos have titles translated into some languages. Currently, these titles are displayed in one of two ways in:

  1. In their native language. It is displayed in:
    • Video playback view
    • Video search view
  2. In the language set as the UI language in FreeTube (Settings ⇾ General settings ⇾ Language preference). It is displayed in:
    • Channel view with thumbnail list of videos.
    • Playlists

These inconsistent applying languages may be disturbing, especially for people, who aren't English native speakers and watch videos in their own native languages, but on the other hand prefer to use English language for FreeTube instead of their own native ones.

Proposed Solution

The current setting called 'Language preference' would be applied to the UI only. Of course, it would be renamed to 'Application language'. Next to its dropdown, there would be a setting called 'Video title language', which would be applied to displayed video titles.

How would it work: After a clean installation or after an update, the default setting for 'Video title language' is 'Same as for application'. Let us suppose we have two different languages selected:

If someone encounters a video which has exactly the same languages as selected up here, here's what happens: the video language is presented in Polish. If someone encounters a video which has a title in one language only, then this title is presented without any changes. If someone encounters a video which does not have its title in the preferred video language, but has in the application's language, then it is presented in the application's language (English in this case).

Alternatives Considered

It would be something similar to the solution in the web browsers. They have a separate language setting for UI and a separate list of preferred languages for displaying content. I think this solution might be an overkill, it is worth of consideration.

Issue Labels

new feature

Additional Information

No response

ChunkyProgrammer commented 2 years ago

Could be useful for formatting dates. Sometimes languages are available in the app but not the exact ISO code of the user (language & Country code) https://en.wikipedia.org/wiki/Date_format_by_country

ngoomie commented 1 year ago

If I could also add on to this suggestion: if possible it'd be nice to be able to select multiple languages for video metadata. I watch a lot of videos in English and Japanese, and if I were to set my language to just one of those, then there'll often be Japanese videos with English metadata available or vice versa. Perhaps info on a video's original language could be fetched, compared to a user's list of preferred languages, and if it's present in that list then the original language metadata is shown?