[Bug]: Livechat scrolling down doesn't hide arrow button - Githubissues

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy

https://freetubeapp.io/

GNU Affero General Public License v3.0

13.63k stars 862 forks source link

[Bug]: Livechat scrolling down doesn't hide arrow button #3158

Closed efb4f5ff-1298-471a-8973-3d47447115dc closed 5 months ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Guidelines

[X] I have encountered this bug in the latest release of FreeTube.
[X] I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
[X] I have searched the documentation for information that matches the description of the bug I want to file, without success.
[X] This issue contains only one bug.

Describe the bug

Go to any video with a live chat
Scroll up in the chat
Scroll down in the chat
See that the blue button doesn't disappear and that u still have to scroll down to keep up with recent chats

https://user-images.githubusercontent.com/73130443/217068248-568cf15b-98de-47c7-96f1-339c928540dc.mp4

Expected Behavior

Button should go away and chat should automatically scroll down again. See YT chat for reference.

Issue Labels

visual bug

FreeTube Version

https://github.com/FreeTubeApp/FreeTube/commit/fa8cc07b5e9ebd831b0806cf6384cc6d9005f6e6

Operating System Version

Windows 10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

[X] I have encountered this bug in the latest nightly build.

predystopic-dev commented 1 year ago

Is this fixed already? I can't reproduce it in dev build

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Hi @predystopic-dev sorry for the delayed response. I can still replicate this on my end.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

kommunarr commented 1 year ago

I can specifically replicate this by pressing the scrollbar in the UI, but not by scrolling with my mouse.

kommunarr commented 5 months ago

My analysis from re-discovering this myself:

This does not occur with slow scrolling down. It might have something to do with "momentum" of a faster scroll propelling it to the bottom that's not getting caught by the onscroll event handler (onScroll in watch-video-live-chat.js). I can tell that this is the likely issue because it's not happening when I put that handler logic in a setTimeout with a 100ms delay. That would technically work, but I would like to see if there's a less hacky fix.