FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Feature Request]: Encrypt Password #3221

Open efb4f5ff-1298-471a-8973-3d47447115dc opened 1 year ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Guidelines

Problem Description

Password is stored in clear text.

Proposed Solution

Encrypt password.

Alternatives Considered

None.

Issue Labels

improvement to existing feature

Additional Information

No response

kommunarr commented 11 months ago

(Continuing discussion on data encryption in #4372) It is always worth asking who the intended beneficiaries of a given feature are. Encryption, protection, and gated access to your data are things that you should probably be leaning on your OS and its profile system instead of FreeTube's. So one more lightweight key use case would be enabling to be a way to show videos to children who otherwise won't get access to the whole web in their own profile on the computer, but could use a safe & monitored way to access certain content. If that were the main target audience, full data encryption features would be strong overkill. Or maybe on some type of public device like a library computer to allow people to watch videos with watch progress and other such features disabled. In which case a bit more security is justified.

All that to say, I'm fine with expanding on the security aspect, and this is a very basic improvement, but it needs to start with a discussion on the intended use cases and threat models.